Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unstable_renderSubtreeIntoContainer to ReactDOM.createPortal() #79

Closed
cjies opened this issue Sep 5, 2017 · 4 comments
Closed

Migrate unstable_renderSubtreeIntoContainer to ReactDOM.createPortal() #79

cjies opened this issue Sep 5, 2017 · 4 comments
Milestone
2.0.x

Comments

@cjies
Copy link
Contributor

cjies commented Sep 5, 2017

Switch from unstable_renderSubtreeIntoContainer() to unstable_createPortal() for compatibility with React Fiber.

Related informations:
@cjies cjies changed the title Replace unstable_renderSubtreeIntoContainer with unstable_createPortal Replace unstable_renderSubtreeIntoContainer to ReactDOM.createPortal() Sep 15, 2017
@cjies cjies changed the title Replace unstable_renderSubtreeIntoContainer to ReactDOM.createPortal() Migrate unstable_renderSubtreeIntoContainer to ReactDOM.createPortal() Sep 15, 2017
@cjies
Copy link
Contributor Author

cjies commented Sep 15, 2017

ReactDOM.createPortal() is official now :) facebook/react#10675

@cjies cjies mentioned this issue Sep 27, 2017
Closed
8 tasks
@cjies
Copy link
Contributor Author

cjies commented Oct 24, 2017

unstable_renderSubtreeIntoContainer do no work in enzyme v3... 😕

And portal components are not supported in enzyme yet. (enzymejs/enzyme#252)

@cjies cjies mentioned this issue Oct 25, 2017
Merged
@zhusee2 zhusee2 added this to the Version 2 milestone Nov 9, 2017
@cjies
Copy link
Contributor Author

cjies commented Jan 12, 2018

enzyme-adpater-react-16 v1.1.0 starts to support React Portal.
enzymejs/enzyme@3ebc14a#diff-c8bcb273fce5646f5438ffc519373594

Planning to upgrade React, Jest and Enzyme.

@zhusee2
Copy link
Contributor

zhusee2 commented Dec 6, 2018

Addressed in #188.

@zhusee2 zhusee2 closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.x
Development

No branches or pull requests
2 participants
@zhusee2 @cjies