Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix Docker Builds #3377

Closed
iBotPeaches opened this issue Oct 7, 2023 · 1 comment
Closed

[BUG] Fix Docker Builds #3377

iBotPeaches opened this issue Oct 7, 2023 · 1 comment
Milestone
v2.9.1

Comments

@iBotPeaches
Copy link
Owner

iBotPeaches commented Oct 7, 2023 •
edited
Loading

Support temporary volumes/mounts for internal frameworks & aapt(2) copies.
@iBotPeaches
Copy link
Owner Author

This is a bit over my head at the moment.

  • Apktool needs the apk, but then writes the output somewhere
  • It writes frameworks into ~ somewhere
  • It writes aapt/aapt2 into /tmp somewhere

So when folks mount a volume 1/1 into container - we don't have the other chunks covered. We basically need a tmpfs for the aapt/aapt2 and internal frameworks and some helper script to mount the intended apk (read only) into container, with some volume/mount to write the output.

@iBotPeaches iBotPeaches mentioned this issue Oct 7, 2023
Merged
@iBotPeaches iBotPeaches added this to the v2.9.1 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.1
Development

No branches or pull requests
1 participant
@iBotPeaches