[BUG] Segfault at runtime after building resources on Android 11 and below #3261
Comments
|
I'll peek tomorrow, but my gut says it's this regression #3199 |
|
On the spot! Oddly enough, a search for a duplicate using the first line of the backtrace did not yield your mentioned issue. I will close this issue because it is a duplicate; if it is not after any further investigations, you may reopen it; thanks! |
|
Okay, odd I thought that would have been it. Thanks for details, I'll try and run it through. However you closed it again, so maybe it is solved. I'll wait and see. |
|
@iBotPeaches Sorry that I was unclear; you are entirely correct, this was a duplicate of #3199. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Information
apktool -version) - 2.8.1java --version) - 11Stacktrace/Logcat
Steps to Reproduce
This one is a bit tricky because this issue is not reproducible by APKTool only because the error happens in the YouTube app, which needs additional changes to be able to install it (changing package name)
TLDR summary:
Full summary:
ReVanced has discovered the issue. ReVanced has forked APKTool. The fork changes a few minor things allowing it to run on Android. When decoding resources with APKTool upstream, the output resource folder is the same as the one made by the fork (checked via a diff). This rules out any errors at the decoding phase that the fork of APKTool can cause.
The following error margin would be building, though, because nearly no changes were made by the fork in this regard, it is unlikely to be the error cause. Right before AAPT2 is executed, no differences between the fork and upstream could be observed. The executed command is the same in the fork and upstream.
https://android.googlesource.com/platform/frameworks/base/+/master/libs/androidfw/LoadedArsc.cpp#357
The error may be reproduced in the following way:
It may be possible to find the root cause of the problem by using
git bisect.The issue is doubtful to be caused by anything other than upstream APKTool; if needed, I will be able to clarify why.
The error may be caused by some framework files updated in APKTool.
The error may originate from AAPT2 itself.
APK
If this APK can be freely shared, please upload/attach a link.
Untouched: https://www.apkmirror.com/apk/google-inc/youtube/youtube-18-23-35-release/
Touched: https://easyupload.io/9i8sjt
Questions to ask before submission
apktool d,apktool bwithout changing anything? No, this step is unfortunately not possible, see the summary aboveThe text was updated successfully, but these errors were encountered: