-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for fish shell #59
Comments
+1 |
1 similar comment
+1 |
Fish doesn't really care about POSIX compatiblity. This is going to be hard.... |
Hey, I actually started working on this (ahem, a month ago, wanted to create a pull request but got distracted). Now, I'm not a fish nor bash expert, but the tests pass and the only thing I was having trouble with was exposing AUTOENV_CUR_FILE and AUTOENV_CUR_DIR. I have my code at https://github.com/loopbit/autoenv, all my changes are in two new files, activate.fish and tests/simple_comment_test.fish |
@Miguel-Alonso Thank you very much for the contribution! I knew fish syntax was different but I thought it was at least mostly compatible with bash/sh. The work of your PR shows me otherwise: Instead, they tried to reinvent the shell. So instead, it would be much wiser to leave the fish part out of autoenv. You could create a new repository from scratch without the bash/dash code and we could link to each other in the readmes. |
No problem at all, what you say makes total sense (and yeah, the decision to rewrite fish from scratch is weird, to say the least, but it is a nice shell). I've just created a new repository at loopbit/autoenv_fish to keep the fish stuff. I'll make it clear in the README that it is just a translation of this project and, probably, a few versions behind the original 😄. As for moving forward, what I'll probably do is to keep an eye on your tests and base my work on that. Does that sound good to you? |
@Miguel-Alonso As you can tell from my commit: it sounds perfect to me. Thank you! |
No description provided.
The text was updated successfully, but these errors were encountered: