BESU-128: Fix WebSocket frames handling #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated WebSocketService (handle -> textMessageHandle) * Updated WebSocketRequestHandler to accept String instead of Buffer Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
shemnon
approved these changes
Nov 21, 2019
| @@ -182,4 +185,34 @@ public void handleLoginRequestWithAuthDisabled() { | |||
| request.putHeader("Content-Type", "application/json; charset=utf-8"); | |||
| request.end("{\"username\":\"user\",\"password\":\"pass\"}"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void webSocketDoesNotToHandlePingPayloadAsJsonRpcRequest(final TestContext context) { | |||
There was a problem hiding this comment.
Yea, it would have taken me way longer to figure out how to test this. 👍
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
sambacha
added a commit
to blockarraygroup/besu
that referenced
this pull request
Nov 22, 2019
BESU-128: Fix WebSocket frames handling (hyperledger#210) Co-authored-by: Lucas Saldanha <lucas.saldanha@consensys.net>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
* Updated WebSocketService (handle -> textMessageHandle) * Updated WebSocketRequestHandler to accept String instead of Buffer Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
* Updated WebSocketService (handle -> textMessageHandle) * Updated WebSocketRequestHandler to accept String instead of Buffer Signed-off-by: Lucas Saldanha <lucas.saldanha@consensys.net> Signed-off-by: edwardmack <ed@edwardmack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description