Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #352

Merged
merged 1 commit into from
May 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Actions/GeneratesNavigationMenu.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

/**
* Generate the dynamic navigation menu.
*
* @todo #350 Replace hard-coded source paths with page model properties
*/
class GeneratesNavigationMenu
Expand Down
4 changes: 3 additions & 1 deletion src/Concerns/Internal/FileHelpers.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

/**
* Offloads file helper methods for the Hyde Facade.
*
*
* If a method uses the name `path` it refers to an internal file path.
* if a method uses the name `link` it refers to a web link used in Blade templates.
*
Expand Down Expand Up @@ -75,6 +75,7 @@ public static function vendorPath(string $path = ''): string

/**
* Format a link to an HTML file, allowing for pretty URLs, if enabled.
*
* @see \Tests\Unit\FileHelperPageLinkPrettyUrlTest
*/
public static function pageLink(string $destination): string
Expand All @@ -90,6 +91,7 @@ public static function pageLink(string $destination): string

/**
* Inject the proper number of `../` before the links in Blade templates.
*
* @see \Tests\Unit\FileHelperRelativeLinkTest
*
* @param string $destination relative to `_site` directory on compiled site
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/FileHelperRelativeLinkTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function test_helper_returns_string_as_is_if_current_is_not_set()
$this->assertEquals('foo/bar.html', Hyde::relativeLink('foo/bar.html'));
}

// Test helper injects the proper number of `../`
// Test helper injects the proper number of `../`
public function test_helper_injects_proper_number_of_doubles_slash()
{
$this->assertEquals('../index.html', Hyde::relativeLink('index.html', 'foo/bar.html'));
Expand Down