Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite mobile navigation menus to prevent duplicates #59

Closed
caendesilva opened this issue Apr 1, 2022 · 3 comments · Fixed by #60
Closed

Rewrite mobile navigation menus to prevent duplicates #59

caendesilva opened this issue Apr 1, 2022 · 3 comments · Fixed by #60
Assignees
@caendesilva

Comments

@caendesilva
Copy link
Member

caendesilva commented Apr 1, 2022 •
edited
Loading

Right now we in practise have 4 navigation menus

The main navbar
The mobile navbar

The documentation sidebar
The mobile documentation sidebar

This means we have 4 sets of lists for 2 pairs of data. Keeping these in sync has become an issue, see #58 for an example.
We need a better implementation where both types are merged so we only have one DOM element for the navbar and one DOM element for the sidebar.
@caendesilva caendesilva mentioned this issue Apr 1, 2022
Closed
@caendesilva caendesilva self-assigned this Apr 2, 2022
@caendesilva caendesilva mentioned this issue Apr 2, 2022
Merged
@caendesilva caendesilva linked a pull request Apr 2, 2022 that will close this issue
Rewrite main navigation menu #60
Merged
@caendesilva caendesilva reopened this Apr 2, 2022
@caendesilva
Copy link
Member Author

Reopened as the docs sidebar has not yet been refactored.

@caendesilva
Copy link
Member Author

The sidebar in the docs actually is already using a single DOM element, however the header/navbar is not.

@caendesilva
Copy link
Member Author

caendesilva commented Apr 2, 2022 •
edited
Loading

Resolved in 5b429b9 by referencing the sidebar-header in the sidebar navigation component which contained duplicate content.

caendesilva added a commit that referenced this issue Jun 18, 2022
@caendesilva
Merge pull request #59 from hydephp/change-priority-of-the-automatic-…
2029043 
…docs-link

Change priority of the automatic docs link in the navbar so it is after standard pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caendesilva caendesilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite main navigation menu hydephp/framework
1 participant
@caendesilva