Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract shared logic in Markdown parsers to trait #161

Closed
caendesilva opened this issue Apr 21, 2022 · 1 comment
Closed

Extract shared logic in Markdown parsers to trait #161

caendesilva opened this issue Apr 21, 2022 · 1 comment
Assignees
@caendesilva

Comments

@caendesilva
Copy link
Member

The following snippet is present in several files and should be merged into a trait

if (isset($document->matter['title'])) {
  $this->title = $document->matter['title'];
} else {
  $this->title = $this->findTitleTag($document->body) ??
      Hyde::titleFromSlug($this->slug);
}
@caendesilva
Copy link
Member Author

Implemented the trait. Replacing usages now.

@caendesilva caendesilva self-assigned this Apr 21, 2022
caendesilva added a commit to hydephp/hyde that referenced this issue Apr 21, 2022
@caendesilva
Add the test for hydephp/framework#161
1a9a735
caendesilva added a commit to hydephp/develop that referenced this issue Jun 7, 2022
@caendesilva
Add the test for hydephp/framework#161
d4ca7b9
caendesilva pushed a commit that referenced this issue Jul 3, 2022
Merge pull request #161 from hydephp/refactor-hydeserviceprovider
d7dc697 
Refactor the HydeServiceProvider structure hydephp/develop@4515f09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caendesilva caendesilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caendesilva