Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename foundation collection facades #981

Merged
merged 5 commits into from
Feb 12, 2023

Conversation

caendesilva
Copy link
Member

Rename foundation collection facades

Old New
Hyde\Foundation\Facades\FileCollection Hyde\Foundation\Facades\Files
Hyde\Foundation\Facades\PageCollection Hyde\Foundation\Facades\Pages
Hyde\Foundation\Facades\Router Hyde\Foundation\Facades\Router

This provides two benefits:

  1. First, better IDE autocompletion as the facades will not conflict with the underlying classes.
  2. And second, they would match the syntax of Hyde::files(), Hyde::pages(), and Hyde::routes().

Fixes #980

@caendesilva caendesilva linked an issue Feb 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #981 (8a4f571) into master (8cb6a7e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8a4f571 differs from pull request most recent head 8f68520. Consider uploading reports for the commit 8f68520 to get more accurate results

@@              Coverage Diff              @@
##              master      #981     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1264      2528   +1264     
=============================================
  Files            150       300    +150     
  Lines           3332      6664   +3332     
=============================================
+ Hits            3332      6664   +3332     
Impacted Files Coverage Δ
...ckages/framework/src/Foundation/Facades/Routes.php 100.00% <ø> (ø)
...framework/src/Foundation/Kernel/FileCollection.php 100.00% <ø> (ø)
.../src/Console/Commands/RebuildStaticPageCommand.php 100.00% <100.00%> (ø)
...ackages/framework/src/Foundation/Facades/Files.php 100.00% <100.00%> (ø)
...ackages/framework/src/Foundation/Facades/Pages.php 100.00% <100.00%> (ø)
...amework/Features/Navigation/BaseNavigationMenu.php 100.00% <100.00%> (ø)
...ework/Features/Navigation/DocumentationSidebar.php 100.00% <100.00%> (ø)
...mework/src/Framework/Services/DiscoveryService.php 100.00% <100.00%> (ø)
...ramework/src/Framework/Services/RebuildService.php 100.00% <100.00%> (ø)
packages/framework/src/Pages/Concerns/HydePage.php 100.00% <100.00%> (ø)
... and 151 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review February 12, 2023 12:10
@caendesilva caendesilva merged commit c430ff2 into master Feb 12, 2023
@caendesilva caendesilva deleted the rename-foundation-collection-facades branch February 12, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename foundation collection facades?
1 participant