Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the validating command class to reduce repeated code #888

Merged
merged 7 commits into from
Jan 30, 2023

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #888 (87e880e) into publications-feature (ae6e970) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature      #888     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3234      1615   -1619     
==========================================================
  Files                         348       174    -174     
  Lines                        8024      4010   -4014     
==========================================================
- Hits                         8024      4010   -4014     
Impacted Files Coverage Δ
...es/publications/src/Commands/ValidatingCommand.php 100.00% <0.00%> (ø)
...blications/src/Commands/MakePublicationCommand.php
...cations/src/Commands/MakePublicationTagCommand.php
...s/src/Commands/ValidatePublicationTypesCommand.php
...tions/src/Commands/ValidatePublicationsCommand.php
...es/publications/src/Commands/ValidatingCommand.php
packages/framework/src/Pages/Concerns/HydePage.php
...ures/BuildTasks/PostBuildTasks/GenerateSitemap.php
...rc/Framework/Factories/Concerns/CoreDataObject.php
.../Framework/Features/Metadata/GlobalMetadataBag.php
... and 165 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 30, 2023 13:39
@caendesilva caendesilva merged commit 3bd29a0 into publications-feature Jan 30, 2023
@caendesilva caendesilva deleted the refactor-validating-command branch January 30, 2023 13:39
caendesilva added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants