Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publication page validation #843

Merged
merged 230 commits into from
Jan 20, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 18, 2023

About

Refactors the publication page validator to match the publication type validator, both in underlying implementation (Laravel Validators) and presentation. The validation logic is now moved to an action, and the command is dedicated to (optionally) selecting which publication(s) to validate, and then displaying the validation results.

Before screenshot

before

After screenshot

after

After screenshot (With a warning + verbose output)

image

*The invalid field counter has been fixed since taking the screenshot

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #843 (cf5de0a) into publications-feature (1818fb9) will not change coverage.
The diff coverage is n/a.

❗ Current head cf5de0a differs from pull request most recent head 4988a6a. Consider uploading reports for the commit 4988a6a to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature      #843     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3190      1601   -1589     
==========================================================
  Files                         346       174    -172     
  Lines                        7920      3984   -3936     
==========================================================
- Hits                         7920      3984   -3936     
Impacted Files Coverage Δ
...cations/src/Actions/PublicationSchemaValidator.php 100.00% <0.00%> (ø)
...tions/src/Commands/ValidatePublicationsCommand.php 100.00% <0.00%> (ø)
...cations/src/Actions/PublicationSchemaValidator.php
...tions/src/Commands/ValidatePublicationsCommand.php
...es/publications/src/Commands/ValidatingCommand.php
...ework/Features/Navigation/DocumentationSidebar.php
...ions/src/Concerns/ParsesPublicationFieldInputs.php
...rk/src/Framework/Factories/BlogPostDataFactory.php
...res/DataCollections/Facades/MarkdownCollection.php
packages/framework/src/Support/Models/RouteKey.php
... and 166 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 20, 2023 18:41
@caendesilva caendesilva force-pushed the refactor-publication-page-validation branch from cfbc2f3 to 3461749 Compare January 20, 2023 18:42
@caendesilva caendesilva merged commit 362406b into publications-feature Jan 20, 2023
@caendesilva caendesilva deleted the refactor-publication-page-validation branch January 20, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants