Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a publication type validation command and helpers #841

Merged
merged 50 commits into from
Jan 18, 2023
Merged

Add a publication type validation command and helpers #841

merged 50 commits into from
Jan 18, 2023

Commits on Jan 17, 2023

  1. Create crude validation method for publication types

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    a09cd86 View commit details
    Browse the repository at this point in the history

  2. Add todos

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c09a121 View commit details
    Browse the repository at this point in the history

  3. Test with invalid schema

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1a8b68e View commit details
    Browse the repository at this point in the history

  4. Refactor to use the Illuminate validator

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c76de85 View commit details
    Browse the repository at this point in the history

  5. Test with fields

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    ba05c6f View commit details
    Browse the repository at this point in the history

  6. Test with invalid fields

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    54dd038 View commit details
    Browse the repository at this point in the history

  7. Refactor to use the Illuminate validator

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8b755ea View commit details
    Browse the repository at this point in the history

  8. Merge Illuminate validator calls

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8c4e69f View commit details
    Browse the repository at this point in the history

  9. Coalesce to null for optional fields

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    03a2a42 View commit details
    Browse the repository at this point in the history

  10. Use prohibited rule to disallow directory schema property

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    7b6a69d View commit details
    Browse the repository at this point in the history

  11. Make directory rule nullable

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    d435d72 View commit details
    Browse the repository at this point in the history

  12. Specify allowed array keys

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    94c1d6d View commit details
    Browse the repository at this point in the history

  13. Revert "Specify allowed array keys" 

    This reverts commit 94c1d6d.
    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    baed80c View commit details
    Browse the repository at this point in the history

  14. Fix mismatched property names

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    5389235 View commit details
    Browse the repository at this point in the history

  15. Test with invalid directory

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    743b13e View commit details
    Browse the repository at this point in the history

  16. Expect ValidationExceptions

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    52ef438 View commit details
    Browse the repository at this point in the history

  17. Add option to buffer and return validation failures

    @caendesilva
    caendesilva committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    caf36bb View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Test complete buffered output

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    43d1124 View commit details
    Browse the repository at this point in the history

  2. Move publication schema validation logic to service

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    2956011 View commit details
    Browse the repository at this point in the history

  3. Add option to only validate the schemas

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d7f2a53 View commit details
    Browse the repository at this point in the history

  4. Display field errors

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c8d1624 View commit details
    Browse the repository at this point in the history

  5. Split out publication type validation to new command class

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    4be5a47 View commit details
    Browse the repository at this point in the history

  6. Introduce local variables

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    3dda1ac View commit details
    Browse the repository at this point in the history

  7. Update title

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    210e347 View commit details
    Browse the repository at this point in the history

  8. Split out display logic

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d9a6366 View commit details
    Browse the repository at this point in the history

  9. Reorder helper methods

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    85dece4 View commit details
    Browse the repository at this point in the history

  10. Import used functions

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    4c4d284 View commit details
    Browse the repository at this point in the history

  11. Remove unused imports

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    a84e601 View commit details
    Browse the repository at this point in the history

  12. Register the command

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    2747ff4 View commit details
    Browse the repository at this point in the history

  13. Inline local variables

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    f1635e3 View commit details
    Browse the repository at this point in the history

  14. Clarify PHPDoc comment

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    5e97c07 View commit details
    Browse the repository at this point in the history

  15. Remove unused class constants

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d83f72b View commit details
    Browse the repository at this point in the history

  16. Replace class property with local variable

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    ccdab4a View commit details
    Browse the repository at this point in the history

  17. Reorder execution flow to merge conditionals

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    6b19fcc View commit details
    Browse the repository at this point in the history

  18. Throw if there are no schema files to validate

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d388934 View commit details
    Browse the repository at this point in the history

  19. Bring out title to run before validation

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c483f74 View commit details
    Browse the repository at this point in the history

  20. Create custom function to get accurate error count

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    5b2c320 View commit details
    Browse the repository at this point in the history

  21. Create ValidatePublicationTypesCommandTest.php

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b662cd8 View commit details
    Browse the repository at this point in the history

  22. Add output expectations

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    835ae27 View commit details
    Browse the repository at this point in the history

  23. Test with multiple publication types

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    88f1058 View commit details
    Browse the repository at this point in the history

  24. Test with no field definitions

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    f9ec892 View commit details
    Browse the repository at this point in the history

  25. Test with Json output

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    2e8ab1f View commit details
    Browse the repository at this point in the history

  26. Add additional Json test

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    9a343df View commit details
    Browse the repository at this point in the history

  27. Extract code to setup method

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    24d4c21 View commit details
    Browse the repository at this point in the history

  28. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    618f202 View commit details
    Browse the repository at this point in the history

  29. Merge branch 'publications-feature' into publication-type-validation

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    0798d8f View commit details
    Browse the repository at this point in the history

  30. Revert "Display field errors" 

    This reverts commit c8d1624.
    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    8ec0267 View commit details
    Browse the repository at this point in the history

  31. Revert "Add option to only validate the schemas" 

    This reverts commit d7f2a53.
    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    dee1660 View commit details
    Browse the repository at this point in the history

  32. Refactor to use the publication name as argument

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    9333ae9 View commit details
    Browse the repository at this point in the history

  33. Inline local variable

    @caendesilva
    caendesilva committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    858469c View commit details
    Browse the repository at this point in the history