Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual page improvements #831

Merged
merged 20 commits into from
Jan 13, 2023
Merged

Virtual page improvements #831

merged 20 commits into from
Jan 13, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 13, 2023

Makes improvements to VirtualPage.php, such as

  • Support Blade rendering of anonymous view files (any arbitrary project file path)
  • Custom instance macros (more or less based on the Illuminate Macroable trait (MIT) but refactored to work on the instance not static class. The idea is that there will be very few virtual page instances around, if there are many it might be better to create a dedicated page class)

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #831 (86002fa) into master (c722742) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master      #831     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1203      2418   +1215     
=============================================
  Files            145       290    +145     
  Lines           3171      6372   +3201     
=============================================
+ Hits            3171      6372   +3201     
Impacted Files Coverage Δ
packages/framework/src/Pages/VirtualPage.php 100.00% <100.00%> (ø)
...packages/framework/src/Pages/Concerns/HydePage.php 100.00% <0.00%> (ø)
...Markdown/Processing/CodeblockFilepathProcessor.php 100.00% <0.00%> (ø)
...c/Framework/Actions/CreatesNewMarkdownPostFile.php 100.00% <0.00%> (ø)
.../packages/framework/src/Foundation/Application.php 100.00% <0.00%> (ø)
...src/Framework/Exceptions/FileNotFoundException.php 100.00% <0.00%> (ø)
...ramework/src/Console/Commands/BuildSiteCommand.php 100.00% <0.00%> (ø)
...c/Foundation/Concerns/BaseFoundationCollection.php 100.00% <0.00%> (ø)
...amework/src/Console/Concerns/AsksToRebuildSite.php 100.00% <0.00%> (ø)
...rc/Framework/Services/YamlConfigurationService.php 100.00% <0.00%> (ø)
... and 136 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 13, 2023 17:19
@caendesilva caendesilva merged commit 989b308 into master Jan 13, 2023
@caendesilva caendesilva deleted the virtual-page-improvements branch January 13, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants