Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline publication type creation and pagination internals #830

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #830 (ad7fbad) into publications-feature (41732a6) will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             publications-feature      #830   +/-   ##
========================================================
  Coverage                  100.00%   100.00%           
- Complexity                   1516      1525    +9     
========================================================
  Files                         170       172    +2     
  Lines                        3792      3808   +16     
========================================================
+ Hits                         3792      3808   +16     
Impacted Files Coverage Δ
...evelop/packages/framework/src/Facades/Features.php 100.00% <0.00%> (ø)
...velop/packages/framework/src/Pages/VirtualPage.php 100.00% <0.00%> (ø)
...p/packages/framework/src/Foundation/HydeKernel.php 100.00% <0.00%> (ø)
...p/packages/publications/src/PublicationService.php 100.00% <0.00%> (ø)
...ckages/framework/src/Foundation/FileCollection.php 100.00% <0.00%> (ø)
...ckages/framework/src/Foundation/PageCollection.php 100.00% <0.00%> (ø)
...ckages/publications/src/Models/PublicationPage.php 100.00% <0.00%> (ø)
...kages/framework/src/Foundation/RouteCollection.php 100.00% <0.00%> (ø)
...s/publications/src/PublicationsServiceProvider.php 100.00% <0.00%> (ø)
...ramework/src/Console/Commands/RouteListCommand.php 100.00% <0.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 13, 2023 13:14
@caendesilva caendesilva changed the title Streamline the publication type creator command and better integrate pagination settings Streamline publication type creation and pagination internals Jan 13, 2023
…f github.com:hydephp/develop into integrate-pagination-to-the-publication-type-command
@caendesilva caendesilva merged commit 1baf597 into publications-feature Jan 13, 2023
@caendesilva caendesilva deleted the integrate-pagination-to-the-publication-type-command branch January 13, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants