Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract publications package #826

Merged
merged 25 commits into from
Jan 11, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 9, 2023

Extracts the publications feature #685 into a sub-package. The dependencies (like validation and translation are also moved to that package)

TODO

  • Move actions and related code to package
  • Move tests?

@caendesilva
Copy link
Member Author

Okay, that was surprisingly painless. (Famous last words)

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #826 (0407a5c) into publications-feature (df88acc) will not change coverage.
The diff coverage is n/a.

❗ Current head 0407a5c differs from pull request most recent head 41732a6. Consider uploading reports for the commit 41732a6 to get more accurate results

@@                   Coverage Diff                    @@
##             publications-feature      #826   +/-   ##
========================================================
  Coverage                  100.00%   100.00%           
- Complexity                   1513      1516    +3     
========================================================
  Files                         169       170    +1     
  Lines                        3784      3792    +8     
========================================================
+ Hits                         3784      3792    +8     
Impacted Files Coverage Δ
...amework/src/Console/HydeConsoleServiceProvider.php
...ckages/framework/src/Foundation/PageCollection.php
...amework/src/Framework/Actions/SourceFileParser.php
...ications/src/Actions/CreatesNewPublicationPage.php
...ications/src/Actions/CreatesNewPublicationType.php
...blications/src/Actions/PublicationPageCompiler.php
...publications/src/Actions/SeedsPublicationFiles.php
...blications/src/Commands/MakePublicationCommand.php
...cations/src/Commands/MakePublicationTagCommand.php
...ations/src/Commands/MakePublicationTypeCommand.php
... and 329 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the extract-publications-package branch 3 times, most recently from c1c4310 to 9837353 Compare January 10, 2023 11:52
@caendesilva caendesilva force-pushed the extract-publications-package branch 2 times, most recently from e135803 to 1fa0173 Compare January 10, 2023 12:47
@caendesilva caendesilva force-pushed the extract-publications-package branch 2 times, most recently from beaa4ef to 981cd69 Compare January 10, 2023 13:09
@caendesilva caendesilva marked this pull request as ready for review January 11, 2023 11:44
@caendesilva caendesilva merged commit 998a225 into publications-feature Jan 11, 2023
@caendesilva caendesilva deleted the extract-publications-package branch January 11, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants