Inline the publication settings class into the publication type class #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae70c0d as we're not quite ready for that yet
Codecov Report
@@ Coverage Diff @@
## publications-feature #818 +/- ##
==========================================================
Coverage 100.00% 100.00%
+ Complexity 3022 1506 -1516
==========================================================
Files 338 168 -170
Lines 7558 3769 -3789
==========================================================
- Hits 7558 3769 -3789 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
We might even want to sort the collection on parse |
This reverts commit 9dac3ac.
caendesilva
force-pushed
the
inline-publication-settings-class
branch
from
b5665a4
to
34a9f1f
Compare
caendesilva
force-pushed
the
inline-publication-settings-class
branch
from
40b7f48
to
ceb0348
Compare
caendesilva
changed the title
caendesilva
changed the title
This actually matches the previous behaviour where the pagination array was empty by default (and thus considered disabled)
This reverts commit 6f829da.
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this class has now been simplified, and both sortField and sortAscending can be used outside of pagination, this class is now longer needed and can be inlined into the PublicationType class.