Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve publication feature testing #815

Merged
merged 33 commits into from
Jan 8, 2023
Merged

Improve publication feature testing #815

merged 33 commits into from
Jan 8, 2023

Commits on Jan 8, 2023

  1. Create StaticSiteBuilderPublicationModuleTest.php

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    8cddd6b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'publications-feature' into add-additional-tests-for-the… 

    …-compiling-of-publication-pages
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    fbd9cf5 View commit details
    Browse the repository at this point in the history

  3. Add method stubs

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    2788977 View commit details
    Browse the repository at this point in the history

  4. Create setUp method to throw on console exceptions during the tests

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    24698f1 View commit details
    Browse the repository at this point in the history

  5. Start sketching up filesystem for test

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    7317d38 View commit details
    Browse the repository at this point in the history

  6. Mark unfinished tests as incomplete

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    004cc50 View commit details
    Browse the repository at this point in the history

  7. Update publications seeder to seed Markdown body content

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    f5bba61 View commit details
    Browse the repository at this point in the history

  8. Create using action instead of through command

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    417af7a View commit details
    Browse the repository at this point in the history

  9. Create method to get test collection for fields covering all types

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    b50e9f7 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'publications-feature' into add-additional-tests-for-the… 

    …-compiling-of-publication-pages
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    4c0b7f6 View commit details
    Browse the repository at this point in the history

  11. Add filesystem assertions

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    68b0099 View commit details
    Browse the repository at this point in the history

  12. Build the site and run baseline assertions

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    d81075c View commit details
    Browse the repository at this point in the history

  13. Structure test method

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    0b085eb View commit details
    Browse the repository at this point in the history

  14. Update test class documentation

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    23fe361 View commit details
    Browse the repository at this point in the history

  15. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    21ec575 View commit details
    Browse the repository at this point in the history

  16. Include index in foreach

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    adbceeb View commit details
    Browse the repository at this point in the history

  17. Set the tagGroup for tag fields

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    044bbf7 View commit details
    Browse the repository at this point in the history

  18. Seed publications

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    ff0afdb View commit details
    Browse the repository at this point in the history

  19. Split out count to expression to make it more readable 

    I think it makes it more clear where the number comes from
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    163a3f2 View commit details
    Browse the repository at this point in the history

  20. Test with the seeded files

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    2293f1d View commit details
    Browse the repository at this point in the history

  21. Split out the extensive test as we only need to test that once 

    The rest of the tests we can use simpler data
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    0f1c44f View commit details
    Browse the repository at this point in the history

  22. Simplify subsequent test case as it does not need to retest everything 

    And this allows us to be stricter in our expectations as we know all the filenames that should be generated
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    d27b882 View commit details
    Browse the repository at this point in the history

  23. Extract method

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    8041cca View commit details
    Browse the repository at this point in the history

  24. Use assertSame

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    dd9259a View commit details
    Browse the repository at this point in the history

  25. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    5e6f7fa View commit details
    Browse the repository at this point in the history

  26. Reorder test mehods

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    1c9330b View commit details
    Browse the repository at this point in the history

  27. Import used functions

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    a0cec1b View commit details
    Browse the repository at this point in the history

  28. Implement the test

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    77b8c5a View commit details
    Browse the repository at this point in the history

  29. Test compiling with paginated publication type

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    3e14966 View commit details
    Browse the repository at this point in the history

  30. Update incomplete test

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    93d63ba View commit details
    Browse the repository at this point in the history

  31. Add todo

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    43a83fd View commit details
    Browse the repository at this point in the history

  32. Merge branch 'publications-feature' into add-additional-tests-for-the… 

    …-compiling-of-publication-pages
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    5bc340f View commit details
    Browse the repository at this point in the history

  33. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    f8dc263 View commit details
    Browse the repository at this point in the history