Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the tagGroup option for publication tag fields #804

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 3, 2023

Adds back the tagGroup option for publication tag fields and adds a few tests and minor refactors for the publication type code.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #804 (63c8ea0) into publications-feature (aa95454) will not change coverage.
The diff coverage is n/a.

❗ Current head 63c8ea0 differs from pull request most recent head 2957950. Consider uploading reports for the commit 2957950 to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature      #804     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   2888      1450   -1438     
==========================================================
  Files                         334       167    -167     
  Lines                        7254      3644   -3610     
==========================================================
- Hits                         7254      3644   -3610     
Impacted Files Coverage Δ
...rk/src/Console/Commands/MakePublicationCommand.php 100.00% <0.00%> (ø)
...rc/Console/Commands/MakePublicationTypeCommand.php 100.00% <0.00%> (ø)
...k/Features/Publications/Models/PublicationTags.php 100.00% <0.00%> (ø)
...k/Features/Publications/Models/PublicationType.php 100.00% <0.00%> (ø)
...Publications/Models/PublicationFieldDefinition.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php
...rc/Console/Commands/MakePublicationTypeCommand.php
...c/Console/Commands/ValidatePublicationsCommand.php
...Publications/Models/PublicationFieldDefinition.php
...k/Features/Publications/Models/PublicationTags.php
... and 162 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 4, 2023 16:01
@caendesilva caendesilva merged commit 8a55834 into publications-feature Jan 4, 2023
@caendesilva caendesilva deleted the add-back-publications-tagGroup-field branch January 4, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants