Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publication field internal class structure #795

Merged
merged 44 commits into from
Jan 1, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 31, 2022

Refactors the new value classes to reduce overlapping code and complexity and improve their integrations into the codebase.

Notable changes:

  • Rename class PublicationField to PublicationFieldDefinition 5678742

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #795 (563b993) into publications-feature (39ee7e1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             publications-feature     #795     +/-   ##
=========================================================
  Coverage                   99.80%   99.80%             
+ Complexity                   2854     1438   -1416     
=========================================================
  Files                         350      175    -175     
  Lines                        7174     3611   -3563     
=========================================================
- Hits                         7160     3604   -3556     
+ Misses                         14        7      -7     
Impacted Files Coverage Δ
...rk/Features/Publications/PublicationFieldTypes.php 86.36% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php
...rc/Console/Commands/MakePublicationTypeCommand.php
...c/Console/Commands/ValidatePublicationsCommand.php
...rc/Framework/Actions/CreatesNewPublicationPage.php
...rk/src/Framework/Actions/SeedsPublicationFiles.php
...Publications/Models/PublicationFieldDefinition.php
...ications/Models/PublicationFields/BooleanField.php
...ls/PublicationFields/Concerns/CanonicableTrait.php
...cations/Models/PublicationFields/DatetimeField.php
... and 190 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Refactor publication field internals Refactor publication field internal class structure Jan 1, 2023
@caendesilva caendesilva marked this pull request as ready for review January 1, 2023 21:16
@caendesilva caendesilva merged commit 51c54dd into publications-feature Jan 1, 2023
@caendesilva caendesilva deleted the refactor-publication-field-classes branch January 1, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants