Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor publication page creation internals #793

Merged
merged 38 commits into from
Dec 30, 2022
Merged

Refactor publication page creation internals #793

merged 38 commits into from
Dec 30, 2022

Commits on Dec 30, 2022

  1. Get namespace dynamically

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    cc8620d View commit details
    Browse the repository at this point in the history

  2. Inline fieldClass helper method

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    634ab32 View commit details
    Browse the repository at this point in the history

  3. Extract helper method

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    fcc4b5d View commit details
    Browse the repository at this point in the history

  4. Introduce local variable

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    c55f5ce View commit details
    Browse the repository at this point in the history

  5. Split comma-separated values into multiple lines

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    75bc273 View commit details
    Browse the repository at this point in the history

  6. Get namespace dynamically

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    4e6afd1 View commit details
    Browse the repository at this point in the history

  7. Inline method InputStreamHandler::formatMessage

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    e802e3f View commit details
    Browse the repository at this point in the history

  8. Extract method

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    ca88a3b View commit details
    Browse the repository at this point in the history

  9. Shift method arguments to make helper more generic

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    71dd2db View commit details
    Browse the repository at this point in the history

  10. Join comma-separated values into a single line

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    268944e View commit details
    Browse the repository at this point in the history

  11. Return null for empty selections

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    b22b00f View commit details
    Browse the repository at this point in the history

  12. Move up selection as there's no need to compute namespace if it's empty

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    534e9a5 View commit details
    Browse the repository at this point in the history

  13. Test with skipping inputs

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    716fb42 View commit details
    Browse the repository at this point in the history

  14. Shift newline call to method below

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    4faa3e8 View commit details
    Browse the repository at this point in the history

  15. Merge conditionals for empty input handling

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    5d71684 View commit details
    Browse the repository at this point in the history

  16. Revert "Shift newline call to method below" 

    This reverts commit 4faa3e8.
    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    e292a08 View commit details
    Browse the repository at this point in the history

  17. Refactor collection to be a class property

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    acc590c View commit details
    Browse the repository at this point in the history

  18. Use the infoComment helper to make the same output

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    a668166 View commit details
    Browse the repository at this point in the history

  19. Indent output to match other questions

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    734afc4 View commit details
    Browse the repository at this point in the history

  20. Test image input selects the right file

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    9893a41 View commit details
    Browse the repository at this point in the history

  21. Fix image input selector

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    3025d4d View commit details
    Browse the repository at this point in the history

  22. Test command selects the right publication

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    c5a4df8 View commit details
    Browse the repository at this point in the history

  23. Switch order of tests

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    ac3b425 View commit details
    Browse the repository at this point in the history

  24. Test command selects the right publication using the names

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    17dc2ea View commit details
    Browse the repository at this point in the history

  25. Remove tests for integer selection of publication types as that doesn… 

    …'t actually work in the actual console
    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    7c49339 View commit details
    Browse the repository at this point in the history

  26. Fix publication type selections so they work in real consoles

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    2be5959 View commit details
    Browse the repository at this point in the history

  27. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    632c97a View commit details
    Browse the repository at this point in the history

  28. Add a newline before the end of output

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    ef84c22 View commit details
    Browse the repository at this point in the history

  29. Update finishing message to clarify that everything was completed suc… 

    …cessfully
    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    0a8067d View commit details
    Browse the repository at this point in the history

  30. Style finishing message using the infoComment helper

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    66a96f0 View commit details
    Browse the repository at this point in the history

  31. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    6d2df36 View commit details
    Browse the repository at this point in the history

  32. Add the date for extra test specificity

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    fc8c1cf View commit details
    Browse the repository at this point in the history

  33. Forgot that we mock the date so we can actually use the entire output...

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    5ff6f2c View commit details
    Browse the repository at this point in the history

  34. Revert "Indent output to match other questions" 

    This reverts commit 734afc4.
    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    65cdf06 View commit details
    Browse the repository at this point in the history

  35. Revert "Indent warning message empty collections" 

    This reverts commit 9945e96.
    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    faa293b View commit details
    Browse the repository at this point in the history

  36. Simplify Carbon call as it's format does not matter here 

    We could use date() here but Carbon allows us to travel through time and mock the time for easier testing
    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    38322a0 View commit details
    Browse the repository at this point in the history

  37. Use type cast

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    90e3a7a View commit details
    Browse the repository at this point in the history

  38. Rename helper method

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    6d26e9e View commit details
    Browse the repository at this point in the history