Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom validation rule for booleans #791

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva marked this pull request as ready for review December 30, 2022 16:42
@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #791 (0fbcff6) into publications-feature (c679d89) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature     #791      +/-   ##
==========================================================
- Coverage                   99.77%   99.77%   -0.01%     
+ Complexity                   1427     1425       -2     
==========================================================
  Files                         173      174       +1     
  Lines                        3595     3583      -12     
==========================================================
- Hits                         3587     3575      -12     
  Misses                          8        8              
Impacted Files Coverage Δ
...rk/Features/Publications/PublicationFieldTypes.php 91.30% <0.00%> (ø)
...k/Features/Publications/Validation/BooleanRule.php 0.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php 100.00% <0.00%> (+3.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit ab74573 into publications-feature Dec 30, 2022
@caendesilva caendesilva deleted the refactor-publication-field-values-to-object-oriented-types branch December 30, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants