Refactor the make:publication command to use the new field value objects #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports normalization from the CreatesNewPublicationPage action
…alues-to-object-oriented-types
Resolves todo eb087d3
Codecov Report
@@ Coverage Diff @@
## publications-feature #790 +/- ##
==========================================================
- Coverage 99.86% 99.77% -0.09%
+ Complexity 2856 1427 -1429
==========================================================
Files 346 173 -173
Lines 7178 3595 -3583
==========================================================
- Hits 7168 3587 -3581
+ Misses 10 8 -2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
While this adds an extra loop, it reduces assertion counts. Either way, I'm not that concerned about performance for an action line this.
… it twice in class body This also removes an edge case where the filename different than the canonical entry as the clock could switchover between those calls
caendesilva
deleted the
refactor-publication-field-values-to-object-oriented-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bring better type safety and eventually reduce complexity in the command class and action. See #789
Also makes some refactors to the types themselves and surrounding logics as I now know better how they fit together.