Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the make:publicationType command class #773

Merged
merged 131 commits into from
Dec 24, 2022
Merged

Refactor the make:publicationType command class #773

merged 131 commits into from
Dec 24, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 23, 2022 •
edited
Loading

Attempts to simplify the command code. This also means dropping support for some premature customization options that may be readded in the future.

@codecov
Copy link

codecov bot commented Dec 23, 2022 •
edited
Loading

Codecov Report

Merging #773 (72c9b25) into publications-feature (ba09ad0) will increase coverage by 0.43%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature     #773      +/-   ##
==========================================================
+ Coverage                   98.26%   98.70%   +0.43%     
+ Complexity                   2778     1396    -1382     
==========================================================
  Files                         324      162     -162     
  Lines                        7728     3856    -3872     
==========================================================
- Hits                         7594     3806    -3788     
+ Misses                        134       50      -84
Impacted Files Coverage Δ
.../Features/Publications/Models/PublicationField.php 100.00% <0.00%> (ø)
...eatures/Publications/Models/PaginationSettings.php 100.00% <0.00%> (ø)
...rc/Console/Commands/MakePublicationTypeCommand.php
...rc/Framework/Actions/CreatesNewPublicationType.php
...eatures/Publications/Models/PaginationSettings.php
.../Features/Publications/Models/PublicationField.php
...rk/Features/Publications/PublicationFieldTypes.php
.../src/Framework/Concerns/RegistersFileLocations.php
...rc/Framework/Services/YamlConfigurationService.php
packages/framework/src/Pages/HtmlPage.php
... and 156 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the refactor-MakePublicationTypeCommand-class branch from ce89412 to 8205f09 Compare December 23, 2022 12:10
caendesilva and others added 24 commits December 23, 2022 13:15
@caendesilva
Add array of the field types that can be canonical
422e2b7
@caendesilva
Use a more readable approach for overriding the labels
64cf0f1
@caendesilva
Remove label overrides to reduce complexity and as cases should alrea…
4451803 
…dy be self-describing
@caendesilva
Update helper method to return the enum instance
4932339
@caendesilva
Update expected order
dadf3cb
@caendesilva
Remove overcounter
fc9c3ba
@caendesilva
Rename local parameter to clarify it
50875fd
@caendesilva
Refactor to return the enum type
4007c50
@caendesilva
Use the canonicable array to see if field can be canonical
9df715f
@caendesilva
Warn and default to meta field when there are no selectable options
b5b8718
@caendesilva
Update warning message
56ebb79
@caendesilva
Update question message
198638d
@caendesilva
Split comma-separated values into multiple lines
215819c
@StyleCIBot
Apply fixes from StyleCI
66555a9
@caendesilva
Test the canonicable method
a009421
@caendesilva
Clean up filesystem in teardown method
ef6ed80
@caendesilva
Use built in confirmation helper
3aec858
@caendesilva
Test command with multiple fields of the same name
08ffd7c
@caendesilva
Use strict array validation
aadbbd6
@caendesilva
Sort options for better ease of access
af3d9e6
@caendesilva
Use the built in confirm helper
6cc96cc
@caendesilva
Add option to use default values
4a5d8e3
@caendesilva
Revert "Add option to use default values"
5a9bb3f 
This reverts commit 4a5d8e3.
@caendesilva
Update argument name 'title' to 'name' to match rest of the code
ecd1eb7
@caendesilva caendesilva marked this pull request as ready for review December 24, 2022 10:16
caendesilva and others added 24 commits December 24, 2022 11:20
@caendesilva
Break out code from if block so it also validates argument data
a97de95
@caendesilva
Test existence of files and directories independently of each other
9b1554f
@caendesilva
Use absolute paths for filesystem calls
f424ef3
@caendesilva
Use is_file instead of file_exists
dc7cc6e
@caendesilva
Test conflict handling
4ffa472
@StyleCIBot
Apply fixes from StyleCI
c19f722
@caendesilva
Extract method
22d14ed
@caendesilva
Shift slug call
72e6c5d
@caendesilva
Expand variable name abbreviation
4c4b005
@caendesilva
Shorten and normalize argument description
359d990
@caendesilva
Simplify if
7990cf5
@caendesilva
Extract method
d928bb2
@caendesilva
Add clarifying parentheses
0da2de8
@caendesilva
Move deprecation candidate notice to data object
7655b05
@caendesilva
Expand property name in question output to make message more fluent
24881f0
@caendesilva
Remove redundant arguments
754bbae
@caendesilva
Use expectsConfirmation instead
5d2df5b
@caendesilva
Join comma-separated values into a single line
bd8b153
@caendesilva
Move up helper methods
cb978a8
@caendesilva
Import used function
b304347
@caendesilva
Unwrap line
550b0e3
@StyleCIBot
Apply fixes from StyleCI
3de00f3
@caendesilva
Make action pagination parameters nullable and shift defaults to there
3dba236
@caendesilva
Reorder questions to match data order
72c9b25
@caendesilva caendesilva merged commit 443d4a2 into publications-feature Dec 24, 2022
@caendesilva caendesilva deleted the refactor-MakePublicationTypeCommand-class branch December 24, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot