Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify publication tag handling #770

Merged
merged 20 commits into from
Dec 22, 2022
Merged

Simplify publication tag handling #770

merged 20 commits into from
Dec 22, 2022

Commits on Dec 22, 2022

  1. Breaking: Remove tagGroup from the PublicationField class

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    c7208c7 View commit details
    Browse the repository at this point in the history

  2. Get tag values from the publication type name

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b856d9a View commit details
    Browse the repository at this point in the history

  3. Remove tagGroup from constructor

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1eceb05 View commit details
    Browse the repository at this point in the history

  4. Remove tagGroup from test

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    a3b967a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'publications-feature' into simplify-publication-tag-han… 

    …dling
    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1c565ea View commit details
    Browse the repository at this point in the history

  6. Remove tagGroup from test

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    342120f View commit details
    Browse the repository at this point in the history

  7. Add null safety

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    943307b View commit details
    Browse the repository at this point in the history

  8. Add the selected publication type as command class property

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    fbd8be5 View commit details
    Browse the repository at this point in the history

  9. Get the tags using the publication type name

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9bd55de View commit details
    Browse the repository at this point in the history

  10. Get tags via publication type

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    551ee4b View commit details
    Browse the repository at this point in the history

  11. Use the publication type's name as the tagGroup

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6a3a66c View commit details
    Browse the repository at this point in the history

  12. Use the publication identifier as the tag group

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    168387a View commit details
    Browse the repository at this point in the history

  13. Remove $reload parameters from tag helpers as it is not clear what it… 

    …'s supposed to do
    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    1a97044 View commit details
    Browse the repository at this point in the history

  14. Remove assumed caching as I presume it's premature optimization

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    2697de4 View commit details
    Browse the repository at this point in the history

  15. Inline local variable

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9cd728d View commit details
    Browse the repository at this point in the history

  16. Flip and simplify 'if'

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9709c3c View commit details
    Browse the repository at this point in the history

  17. Simplify method

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    45c11ad View commit details
    Browse the repository at this point in the history

  18. Remove redundant PHPDoc comments

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    be6e6fe View commit details
    Browse the repository at this point in the history

  19. Extract method

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    f5ab9e9 View commit details
    Browse the repository at this point in the history

  20. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    d552077 View commit details
    Browse the repository at this point in the history