Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the PublicationField class #769

Merged
merged 19 commits into from
Dec 21, 2022
Merged

Simplify the PublicationField class #769

merged 19 commits into from
Dec 21, 2022

Commits on Dec 21, 2022

  1. Deprecate publicationType as a class property pending move to method

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    192fdbf View commit details
    Browse the repository at this point in the history

  2. Refactor to move $publicationType from constructor to methods needing it

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e232390 View commit details
    Browse the repository at this point in the history

  3. Update ValidatePublicationsCommand.php

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    664e71c View commit details
    Browse the repository at this point in the history

  4. Update PublicationType.php

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    df4c9d7 View commit details
    Browse the repository at this point in the history

  5. Make $publicationType argument nullable

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0237b8b View commit details
    Browse the repository at this point in the history

  6. Add PHPDoc

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    677d034 View commit details
    Browse the repository at this point in the history

  7. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    8ea6ffa View commit details
    Browse the repository at this point in the history

  8. Put publicationType argument last in method signatures

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    4cb17bf View commit details
    Browse the repository at this point in the history

  9. Update PublicationFieldValidationRulesTest.php

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    9a74df6 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'refactor-to-move-PublicationField-class-property-to-arg… 

    …ument' of github.com:hydephp/develop into refactor-to-move-PublicationField-class-property-to-argument
    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    371787a View commit details
    Browse the repository at this point in the history

  11. Inline testing helper method

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5f67cd6 View commit details
    Browse the repository at this point in the history

  12. Filter the array to not include the tagGroup when it's null

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    67d20f9 View commit details
    Browse the repository at this point in the history

  13. Remove method arguments not present in signature

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    3619223 View commit details
    Browse the repository at this point in the history

  14. Remove unused $reload parameter

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5b26836 View commit details
    Browse the repository at this point in the history

  15. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    24ba375 View commit details
    Browse the repository at this point in the history

  16. Remove unused $reload parameter

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0031441 View commit details
    Browse the repository at this point in the history

  17. Format PHPDoc

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    f8fb2fd View commit details
    Browse the repository at this point in the history

  18. Add PHPDoc

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    7097209 View commit details
    Browse the repository at this point in the history

  19. Update PHPDoc

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    a59de59 View commit details
    Browse the repository at this point in the history