Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor default to publication field type validation rules and allow arbitrary ones to be added #768

Merged
merged 51 commits into from
Dec 22, 2022
Merged

Refactor default to publication field type validation rules and allow arbitrary ones to be added #768

merged 51 commits into from
Dec 22, 2022

Commits on Dec 21, 2022

  1. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d4487ba View commit details
    Browse the repository at this point in the history

  2. Add $rules array to the publication field class

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    1e347da View commit details
    Browse the repository at this point in the history

  3. Merge branch 'publications-feature' into allow-arbitrary-validation-r… 

    …ules-to-be-added-to-publication-field-types
    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d8494fb View commit details
    Browse the repository at this point in the history

  4. Add the rules array to the constructor parameters

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    113b297 View commit details
    Browse the repository at this point in the history

  5. Add validation rules to the array representation

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d57bf42 View commit details
    Browse the repository at this point in the history

  6. Update test link annotation

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    fb968f6 View commit details
    Browse the repository at this point in the history

  7. Rename local variable

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    bc33920 View commit details
    Browse the repository at this point in the history

  8. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    1d93c2a View commit details
    Browse the repository at this point in the history

  9. Actually get the default field rules

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0497261 View commit details
    Browse the repository at this point in the history

  10. Group together related tests

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    acfe602 View commit details
    Browse the repository at this point in the history

  11. Return empty array instead of throwing exception for default validati… 

    …on rules
    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    10f31cb View commit details
    Browse the repository at this point in the history

  12. Remove 'required' from default types validation rules

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    f32cdda View commit details
    Browse the repository at this point in the history

  13. Add todo

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    9cf859e View commit details
    Browse the repository at this point in the history

  14. Join comma-separated values into a single line

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5261fe5 View commit details
    Browse the repository at this point in the history

  15. Remove 'between' from default types validation rules

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d778165 View commit details
    Browse the repository at this point in the history

  16. Change default validation rule to date as datetime is not a valid rule

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    2e48fe2 View commit details
    Browse the repository at this point in the history

  17. Expect rules to contain the default rules

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    a90a010 View commit details
    Browse the repository at this point in the history

  18. Remove duplicated rules added by the default rules

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    55f105d View commit details
    Browse the repository at this point in the history

  19. Merge duplicate switch branches

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    de85904 View commit details
    Browse the repository at this point in the history

  20. Shift default value location to enum to only use dynamic rules in switch

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    b34593e View commit details
    Browse the repository at this point in the history

  21. Add code comment

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    16514e5 View commit details
    Browse the repository at this point in the history

  22. Remove unnecessary switch cases

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    1882f4b View commit details
    Browse the repository at this point in the history

  23. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    9fe9e1a View commit details
    Browse the repository at this point in the history

  24. Add 'numeric' rule to integer type 

    See https://laravel.com/docs/9.x/validation#rule-integer
    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    49c6451 View commit details
    Browse the repository at this point in the history

  25. Merge branch 'allow-arbitrary-validation-rules-to-be-added-to-publica… 

    …tion-field-types' of github.com:hydephp/develop into allow-arbitrary-validation-rules-to-be-added-to-publication-field-types
    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    fe835ea View commit details
    Browse the repository at this point in the history

  26. Expect integer to be numeric

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    b58d657 View commit details
    Browse the repository at this point in the history

  27. Update PublicationFieldTypesEnumTest.php

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    702d161 View commit details
    Browse the repository at this point in the history

  28. Test all default rules to guard against unintentional BC breaks

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    bb7e309 View commit details
    Browse the repository at this point in the history

  29. Update test method name

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    82063e4 View commit details
    Browse the repository at this point in the history

  30. Expect default rule

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    15d0649 View commit details
    Browse the repository at this point in the history

  31. Merge unit test into feature test

    @caendesilva
    caendesilva committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5c3ae0e View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Add base test for the validate method

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    d046b47 View commit details
    Browse the repository at this point in the history

  2. Test with custom validation rules

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    19b5b96 View commit details
    Browse the repository at this point in the history

  3. Replace if with ??=

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    dbfaa91 View commit details
    Browse the repository at this point in the history

  4. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6fba7e5 View commit details
    Browse the repository at this point in the history

  5. Revert "Replace if with ??=" 

    This reverts commit dbfaa91.
    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    c4ffb98 View commit details
    Browse the repository at this point in the history

  6. Use strict comparison

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    fd65b41 View commit details
    Browse the repository at this point in the history

  7. Support both arrays and Arrayables to be passed for custom rules

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    9510bdb View commit details
    Browse the repository at this point in the history

  8. Merge branch 'allow-arbitrary-validation-rules-to-be-added-to-publica… 

    …tion-field-types' of github.com:hydephp/develop into allow-arbitrary-validation-rules-to-be-added-to-publication-field-types
    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b152eda View commit details
    Browse the repository at this point in the history

  9. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    20f5d49 View commit details
    Browse the repository at this point in the history

  10. Merge into 'elseif'

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    f1e0573 View commit details
    Browse the repository at this point in the history

  11. Refactor method

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6325085 View commit details
    Browse the repository at this point in the history

  12. Use generic parameter for helper method

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    db56881 View commit details
    Browse the repository at this point in the history

  13. Introduce local variable

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    03e6e64 View commit details
    Browse the repository at this point in the history

  14. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    362db37 View commit details
    Browse the repository at this point in the history

  15. Apply the custom field rules

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    26b1e88 View commit details
    Browse the repository at this point in the history

  16. Use built in push helper instead of foreach loop

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    ff820a8 View commit details
    Browse the repository at this point in the history

  17. Add baseline test

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    a18f00d View commit details
    Browse the repository at this point in the history

  18. Add testing helper to merge data

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    68f09c6 View commit details
    Browse the repository at this point in the history

  19. Test custom field rules can be deserialized for publication type schemas

    @caendesilva
    caendesilva committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    087b922 View commit details
    Browse the repository at this point in the history

  20. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    165da49 View commit details
    Browse the repository at this point in the history