Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the publication page compiler #757

Merged
merged 24 commits into from
Dec 15, 2022
Merged

Refactor the publication page compiler #757

merged 24 commits into from
Dec 15, 2022

Commits on Dec 15, 2022

  1. Convert test method names to snake_case

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cb20565 View commit details
    Browse the repository at this point in the history

  2. Introduce local variable

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    bafd0c4 View commit details
    Browse the repository at this point in the history

  3. Check if the file exists before attempting to compile

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    194023a View commit details
    Browse the repository at this point in the history

  4. Convert string interpolation to 'sprintf()' calls

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    19a3a65 View commit details
    Browse the repository at this point in the history

  5. Display the relative path in the exception message

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    ad22000 View commit details
    Browse the repository at this point in the history

  6. Add tests for missing views

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    842127b View commit details
    Browse the repository at this point in the history

  7. Extract method for repeated code

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7670946 View commit details
    Browse the repository at this point in the history

  8. Inline local variables

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    bd2d6f9 View commit details
    Browse the repository at this point in the history

  9. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cd94ce0 View commit details
    Browse the repository at this point in the history

  10. Create AnonymousViewCompiler.php

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    1af30f6 View commit details
    Browse the repository at this point in the history

  11. Create AnonymousViewCompilerTest.php

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    4f6f9d5 View commit details
    Browse the repository at this point in the history

  12. Extends InvokableAction

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3eba351 View commit details
    Browse the repository at this point in the history

  13. Add class documentation

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    79cf0c6 View commit details
    Browse the repository at this point in the history

  14. Add class properties and constructor

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d524d77 View commit details
    Browse the repository at this point in the history

  15. Implement the __invoke method

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e423afa View commit details
    Browse the repository at this point in the history

  16. Implement the test

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    4d6abaf View commit details
    Browse the repository at this point in the history

  17. Throw FileNotFoundException on fail instead

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2d2bcdc View commit details
    Browse the repository at this point in the history

  18. Merge branch 'Create-class-AnonymousViewCompiler' into refactor-publi… 

    …cation-page-compiler
    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    36a697c View commit details
    Browse the repository at this point in the history

  19. Merge branch 'publications-feature' of github.com:hydephp/develop int… 

    …o publications-feature
    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cb89aeb View commit details
    Browse the repository at this point in the history

  20. Merge branch 'publications-feature' into refactor-publication-page-co… 

    …mpiler
    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    f41b16c View commit details
    Browse the repository at this point in the history

  21. Refactor to use the AnonymousViewCompiler

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    87584ca View commit details
    Browse the repository at this point in the history

  22. Inline simplified method

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2dc269f View commit details
    Browse the repository at this point in the history

  23. Convert concatenation to a scalar value

    @caendesilva
    caendesilva committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    b1118cf View commit details
    Browse the repository at this point in the history

  24. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    423e09e View commit details
    Browse the repository at this point in the history