Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create enum for publication types #733

Merged
merged 29 commits into from
Dec 5, 2022
Merged

Create enum for publication types #733

merged 29 commits into from
Dec 5, 2022

Conversation

caendesilva
Copy link
Member

As we are starting to get a lot of logic regarding these, I think it might be worth playing around with adding an enum for them.

caendesilva and others added 29 commits December 5, 2022 14:44
@caendesilva
Add class documentation
deafa18
@caendesilva
Create PublicationFieldTypes.php
498cf50
@caendesilva
Create PublicationFieldTypesEnumTest.php
4c81d0e 
Update PublicationFieldTypes.php
@caendesilva
Add class documentation
83714c0
@caendesilva
Add linking annotations between related classes
14c96d4
@caendesilva
Create enum definitions for the supported field types
7401558
@caendesilva
Convert pure enum to backed
48f715f
@caendesilva
Deprecate constants in field type class
6e34d8d
@caendesilva
Fix indentation
f2bfbab
@caendesilva
Copy over default rules constant as protected
c437373
@caendesilva
Create a rules helper method to get rules for the enum instance
fa81733
@caendesilva
Add static helper to get the rules for the given type
efd035e
@caendesilva
Throw if the type has no rules
0bfbed1
@caendesilva
Revert "Copy over default rules constant as protected"
0611518 
This reverts commit c437373.
@caendesilva
Refactor rules method to use the static match helper
0a15332
@caendesilva
Disable PhpDuplicateMatchArmBodyInspection
924c423
@caendesilva
Try on the last match arm
b761a2d
@caendesilva
Remove type constants from the publication field type class
e0e8c96
@caendesilva
Add collect helper to enum
8103946
@caendesilva
Add values helper to enum
f9ac5ec
@caendesilva
Update to use the enum instead of removed constant
87bcc6a
@caendesilva
Refactor to use enum instead of string for internal representation
58123c5
@StyleCIBot
Apply fixes from StyleCI
13766e0
@caendesilva
Use the enum rules helper instead of removed constant
a901489
@StyleCIBot
Apply fixes from StyleCI
3bb5a07
@caendesilva
Code style
adefe81
@caendesilva
Refactor to use the enum
d82a51f
@caendesilva
Merge branch 'extract-publication-type-enum' of github.com:hydephp/de…
f679588 
…velop into extract-publication-type-enum
@StyleCIBot
Apply fixes from StyleCI
28bf846
@caendesilva caendesilva marked this pull request as ready for review December 5, 2022 20:11
@caendesilva caendesilva merged commit 47b44c6 into publications-feature Dec 5, 2022
@caendesilva caendesilva deleted the extract-publication-type-enum branch December 5, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot