Extract class for pagination settings #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
extract-class-for-pagination-settings
branch
from
a3be399
to
48469f9
Compare
Update CreatesNewPublicationPageTest.php Update CreatesNewPublicationType.php Update test-publication-schema.json Update MakePublicationCommandTest.php Update MakePublicationTypeCommandTest.php Update PublicationListPageTest.php Update PublicationPageTest.php Update PublicationPageUnitTest.php
caendesilva
force-pushed
the
extract-class-for-pagination-settings
branch
from
48469f9
to
00f8d49
Compare
caendesilva
force-pushed
the
extract-class-for-pagination-settings
branch
from
d416ba1
to
06653d3
Compare
Update CreatesNewPublicationType.php Update CreatesNewPublicationTypeTest.php Update MakePublicationTypeCommand.php Update MakePublicationTypeCommandTest.php Update PublicationTypeTest.php Update PublicationPageUnitTest.php
caendesilva
force-pushed
the
extract-class-for-pagination-settings
branch
from
77697c9
to
d53e750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the schema for pagination settings for publication types by putting the settings in a sub-array and using a data object internally. It also changes the sort direction string to be a boolean as I don't see the need for sorting in any other way than asc/desc. All in all this leads to a more consistent and predictable schema and state.