Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and add tests for MakePublicationTagCommand #727

Merged
merged 70 commits into from
Dec 3, 2022
Merged

Refactor and add tests for MakePublicationTagCommand #727

merged 70 commits into from
Dec 3, 2022

Commits on Dec 3, 2022

  1. Fix assumed typo in PHPDoc

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    ce83dc9 View commit details
    Browse the repository at this point in the history

  2. Replace self with static

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    3ae42ce View commit details
    Browse the repository at this point in the history

  3. Remove unused parameter from getValuesForTagName helper

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    99e8a40 View commit details
    Browse the repository at this point in the history

  4. Move down method to group tag related code together

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f37d9b9 View commit details
    Browse the repository at this point in the history

  5. Update test annotation

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d528e8d View commit details
    Browse the repository at this point in the history

  6. Break if stream fails

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    3beda9f View commit details
    Browse the repository at this point in the history

  7. Extract method

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    ae1296a View commit details
    Browse the repository at this point in the history

  8. Create MakePublicationTagCommandTest.php

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    99e30b3 View commit details
    Browse the repository at this point in the history

  9. Add helper to mock the standard input stream

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    c157622 View commit details
    Browse the repository at this point in the history

  10. Merge added tags with existing before save

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    2a5ef06 View commit details
    Browse the repository at this point in the history

  11. Implement base test

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    c78dbdf View commit details
    Browse the repository at this point in the history

  12. Display the tag selections

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b950d1c View commit details
    Browse the repository at this point in the history

  13. Add output expectations

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d0bfe8e View commit details
    Browse the repository at this point in the history

  14. Test feed termination

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b22c0f0 View commit details
    Browse the repository at this point in the history

  15. Clean up test code with teardown method

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    93f3948 View commit details
    Browse the repository at this point in the history

  16. Revert "Break if stream fails" 

    This reverts commit 3beda9f.
    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f948687 View commit details
    Browse the repository at this point in the history

  17. Allow tag name to be passed as argument

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    0bd14d6 View commit details
    Browse the repository at this point in the history

  18. Extract method

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    0bc773b View commit details
    Browse the repository at this point in the history

  19. Replace ?? with if

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    97c528e View commit details
    Browse the repository at this point in the history

  20. Fix test method names

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    434b9a0 View commit details
    Browse the repository at this point in the history

  21. Display the tag name selection when using CLI argument

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    0124a48 View commit details
    Browse the repository at this point in the history

  22. Style the output

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    7c7f937 View commit details
    Browse the repository at this point in the history

  23. Add a newline

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    14c79c1 View commit details
    Browse the repository at this point in the history

  24. Add todo

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    25c0f15 View commit details
    Browse the repository at this point in the history

  25. Remove unused import

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    e836e84 View commit details
    Browse the repository at this point in the history

  26. Move down method

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    4a2f3eb View commit details
    Browse the repository at this point in the history

  27. Display clickable filepath link

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    61603c4 View commit details
    Browse the repository at this point in the history

  28. Add todo

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    0f5977d View commit details
    Browse the repository at this point in the history

  29. Use shorter writeln syntax

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6084503 View commit details
    Browse the repository at this point in the history

  30. Add newline and style output

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    292619c View commit details
    Browse the repository at this point in the history

  31. Move variable declaration to just before first usage

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    8148b5e View commit details
    Browse the repository at this point in the history

  32. Use absolute paths for filesystem interactions

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    3bc7bac View commit details
    Browse the repository at this point in the history

  33. Expect absolute path in output

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    087007c View commit details
    Browse the repository at this point in the history

  34. Convert 'sprintf()' call to concatenation

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    66cc546 View commit details
    Browse the repository at this point in the history

  35. Extract formatting helper to base class

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    cfc8246 View commit details
    Browse the repository at this point in the history

  36. Refactor to use info comment helper

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    bf4174f View commit details
    Browse the repository at this point in the history

  37. Introduce local variable for the existing tags

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    0db8cad View commit details
    Browse the repository at this point in the history

  38. Shorten unit test code

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    e824c0b View commit details
    Browse the repository at this point in the history

  39. Fix and test conflict handling

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a229d4d View commit details
    Browse the repository at this point in the history

  40. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    08c9600 View commit details
    Browse the repository at this point in the history

  41. Extract reusable code to helper action

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6348c28 View commit details
    Browse the repository at this point in the history

  42. Normalize output styling

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d42763d View commit details
    Browse the repository at this point in the history

  43. Extract helper methods

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6815b76 View commit details
    Browse the repository at this point in the history

  44. Refactor to inline existingTags variable

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a4757e3 View commit details
    Browse the repository at this point in the history

  45. Refactor to use class properties instead of passing variables around

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    ff74b49 View commit details
    Browse the repository at this point in the history

  46. Inline local variable

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    ee2efe6 View commit details
    Browse the repository at this point in the history

  47. Use the filesystem facade

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    fbae774 View commit details
    Browse the repository at this point in the history

  48. Inline local variable

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    5eccb8b View commit details
    Browse the repository at this point in the history

  49. Split comma-separated values into multiple lines

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    fde02dc View commit details
    Browse the repository at this point in the history

  50. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    cbd9f89 View commit details
    Browse the repository at this point in the history

  51. Clean up code

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6df6df3 View commit details
    Browse the repository at this point in the history

  52. Add method stub with same result as parent for more clear test

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    2a51657 View commit details
    Browse the repository at this point in the history

  53. Add a dynamic test command class

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f48d81a View commit details
    Browse the repository at this point in the history

  54. Test the infoComment helper

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    bc72416 View commit details
    Browse the repository at this point in the history

  55. Allow extra info to be passed to infoComment helper

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a5cfe65 View commit details
    Browse the repository at this point in the history

  56. Use the infoComment helper

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    2f98b8d View commit details
    Browse the repository at this point in the history

  57. Inline local variable

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    35fd2f7 View commit details
    Browse the repository at this point in the history

  58. Introduce new local variable

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    9c821f8 View commit details
    Browse the repository at this point in the history

  59. Extract helper

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    372f462 View commit details
    Browse the repository at this point in the history

  60. Merge unnecessary local variable into single statement

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d183a52 View commit details
    Browse the repository at this point in the history

  61. Inline local variable

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    aa4616a View commit details
    Browse the repository at this point in the history

  62. Swap to use safeHandle method

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f72d43c View commit details
    Browse the repository at this point in the history

  63. Refactor to throw exception instead of returning error directly

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    2dcec09 View commit details
    Browse the repository at this point in the history

  64. Extract method

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    8847e5b View commit details
    Browse the repository at this point in the history

  65. Shift down property assignment to helper method

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a9045d7 View commit details
    Browse the repository at this point in the history

  66. Shorten helper method name

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    e42e3cd View commit details
    Browse the repository at this point in the history

  67. Shift down helper method call

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    d04819d View commit details
    Browse the repository at this point in the history

  68. Revert "Shift down helper method call" 

    This reverts commit d04819d.
    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    dc0964c View commit details
    Browse the repository at this point in the history

  69. Add todo

    @caendesilva
    caendesilva committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    864e8c8 View commit details
    Browse the repository at this point in the history

  70. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6699dda View commit details
    Browse the repository at this point in the history