Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract action for publications compiling #726

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 3, 2022

Since these page types have dynamic source files, their compiling logic is a bit more complex than other pages. This refactor PR moves these to a dedicated action, and adds an experimental base action that adds a static call method to provide syntactic sugar for invokable classes.

The short snippet shows the call method alternative. Both lines to the exact same thing.

return (new PublicationPageCompiler($this))->__invoke();

return PublicationPageCompiler::call($this);

@caendesilva caendesilva marked this pull request as ready for review December 3, 2022 16:54
@caendesilva caendesilva merged commit 11fc176 into publications-feature Dec 3, 2022
@caendesilva caendesilva deleted the extract-action-for-publications-compiling branch December 3, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants