Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Committing code to 'tag' field type. #716

Merged
merged 13 commits into from
Nov 28, 2022
Merged

Committing code to 'tag' field type. #716

merged 13 commits into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. Committing code to 'tag' field type.

    @rgasch
    rgasch committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b4c4fe0 View commit details
    Browse the repository at this point in the history

  2. Strip Windows newlines when detecting feed termination

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3c33952 View commit details
    Browse the repository at this point in the history

  3. Update MakePublicationTypeCommandTest.php

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    feae645 View commit details
    Browse the repository at this point in the history

  4. Cast value to string before trying to trim it

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    b16d131 View commit details
    Browse the repository at this point in the history

  5. Change return type from 'mixed' to 'string'

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4cdae7e View commit details
    Browse the repository at this point in the history

  6. Update MakePublicationTypeCommandTest.php

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d4a518d View commit details
    Browse the repository at this point in the history

  7. Update expected tags

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    32390a7 View commit details
    Browse the repository at this point in the history

  8. Update expected range values to be strings and not null

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7d57a50 View commit details
    Browse the repository at this point in the history

  9. Resolve fixme

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    bcdd6a9 View commit details
    Browse the repository at this point in the history

  10. Partly resolve fixme 

    See https://github.com/hydephp/develop/pull/716/files#r1033349065
    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    47cce7b View commit details
    Browse the repository at this point in the history

  11. Resolve todo

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1129f6d View commit details
    Browse the repository at this point in the history

  12. Resolve fixme

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    61f121e View commit details
    Browse the repository at this point in the history

  13. Apply style changes from StyleCI

    @caendesilva
    caendesilva committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1314bb6 View commit details
    Browse the repository at this point in the history