Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publication commands and create actions #688

Merged
merged 156 commits into from
Nov 25, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 24, 2022

Refactors for better usage of built-in helpers and reduces redundant code. Also improves test coverage.

@caendesilva caendesilva changed the base branch from master to publications-feature November 24, 2022 11:43
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #688 (3ccb1e1) into publications-feature (6c93614) will increase coverage by 3.74%.
The diff coverage is n/a.

❗ Current head 3ccb1e1 differs from pull request most recent head 4fb8491. Consider uploading reports for the commit 4fb8491 to get more accurate results

@@                     Coverage Diff                     @@
##             publications-feature      #688      +/-   ##
===========================================================
+ Coverage                   96.25%   100.00%   +3.74%     
+ Complexity                   1160      1052     -108     
===========================================================
  Files                         142       132      -10     
  Lines                        2994      2606     -388     
===========================================================
- Hits                         2882      2606     -276     
+ Misses                        112         0     -112     
Impacted Files Coverage Δ
packages/framework/src/Facades/Features.php 100.00% <0.00%> (ø)
...ckages/framework/src/Foundation/PageCollection.php 100.00% <0.00%> (ø)
.../framework/src/Framework/Services/BuildService.php 100.00% <0.00%> (ø)
...ramework/src/Console/Commands/BuildSiteCommand.php 100.00% <0.00%> (ø)
...ramework/src/Console/Commands/RouteListCommand.php 100.00% <0.00%> (ø)
...amework/src/Console/HydeConsoleServiceProvider.php 100.00% <0.00%> (ø)
...Markdown/Processing/CodeblockFilepathProcessor.php 100.00% <0.00%> (ø)
...rc/Console/Commands/MakePublicationTypeCommand.php
...amework/src/Console/Concerns/ValidatingCommand.php
...rc/Framework/Actions/CreatesNewPublicationFile.php
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Refactor publication commands Refactor publication commands and create actions Nov 24, 2022
@caendesilva caendesilva marked this pull request as ready for review November 25, 2022 17:59
@caendesilva caendesilva merged commit 2652dd2 into publications-feature Nov 25, 2022
@caendesilva caendesilva deleted the refactor-publication-commands branch November 25, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants