Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and refactor make:publicationType command and add tests for it #678

Merged
merged 19 commits into from
Nov 20, 2022
Merged

Fix and refactor make:publicationType command and add tests for it #678

merged 19 commits into from
Nov 20, 2022

Commits on Nov 20, 2022

  1. Create MakePublicationTypeCommandTest.php

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    4791d4a View commit details
    Browse the repository at this point in the history

  2. Update MakePublicationTypeCommand.php

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    c29de89 View commit details
    Browse the repository at this point in the history

  3. Copilot generate test

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    61cf0bc View commit details
    Browse the repository at this point in the history

  4. Fix critical bug causing command to crash

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    9f9faa2 View commit details
    Browse the repository at this point in the history

  5. Update MakePublicationTypeCommandTest.php

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    b952ee0 View commit details
    Browse the repository at this point in the history

  6. Add expected JSON

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    70ec663 View commit details
    Browse the repository at this point in the history

  7. Add todo

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    c3d1569 View commit details
    Browse the repository at this point in the history

  8. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    1369d91 View commit details
    Browse the repository at this point in the history

  9. Update PHPDoc Comment to match signature

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    b54767d View commit details
    Browse the repository at this point in the history

  10. Add missing method return types

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    edd7e48 View commit details
    Browse the repository at this point in the history

  11. Remove redundant PHPDoc comments inferred by strong types

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    e3092c8 View commit details
    Browse the repository at this point in the history

  12. Remove throws tag for exception that is never thrown

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    9944821 View commit details
    Browse the repository at this point in the history

  13. Remove redundant PHPDoc comments inferred by strong types

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    a6f71a4 View commit details
    Browse the repository at this point in the history

  14. Use dynamic Hyde path for compatibility

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    4e95205 View commit details
    Browse the repository at this point in the history

  15. Remove unused helpers (can be moved back to HydeHelper)

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    5bb5a7f View commit details
    Browse the repository at this point in the history

  16. Fix typo

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    9e22927 View commit details
    Browse the repository at this point in the history

  17. Cleanup code

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    a4645ca View commit details
    Browse the repository at this point in the history

  18. Initialize offset variable

    @caendesilva
    caendesilva committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    d2f5672 View commit details
    Browse the repository at this point in the history

  19. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    c2b72e6 View commit details
    Browse the repository at this point in the history