Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the build service class #666

Merged
merged 14 commits into from
Nov 16, 2022
Merged

Clean up the build service class #666

merged 14 commits into from
Nov 16, 2022

Conversation

caendesilva
Copy link
Member

This refactor only affects the internal code API.

@caendesilva caendesilva marked this pull request as ready for review November 16, 2022 10:42
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #666 (b6bdb57) into master (69e5ba3) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #666   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1049      1049           
===========================================
  Files            132       132           
  Lines           2600      2595    -5     
===========================================
- Hits            2600      2595    -5     
Impacted Files Coverage Δ
.../framework/src/Framework/Services/BuildService.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit ec3c401 into master Nov 16, 2022
@caendesilva caendesilva deleted the refactor-build-service branch November 16, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants