Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DiscoveryService.php #654

Merged
merged 47 commits into from
Nov 8, 2022
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 8, 2022

Major changes:

  • Renames method formatSlugForModel to pathToIdentifier and improves it
  • Adds support for customizing media file extensions with an array
  • Adds more test cases

@what-the-diff
Copy link

what-the-diff bot commented Nov 8, 2022

  • Added a new method to the DiscoveryService class.
  • Updated existing methods in the DiscoveryService class to use this new method instead of duplicating code.
  • Refactored some other parts of the file for readability and consistency with PSR-12 standards (e.g., spacing, indentation).

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #654 (45068ce) into master (e1c92cb) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #654   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1024      1026    +2     
===========================================
  Files            127       127           
  Lines           2551      2554    +3     
===========================================
+ Hits            2551      2554    +3     
Impacted Files Coverage Δ
...mework/src/Framework/Services/DiscoveryService.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 019c742 into master Nov 8, 2022
@caendesilva caendesilva deleted the discovery-service-refactors branch November 8, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants