Refactor the page data factory pipeline #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
refactor-to-use-factories
branch
from
89e48dc
to
7f51c5d
Compare
|
FeaturedImageFactory doesn't need to use the CDO as it only needs to know about the front matter. |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the factories, by design, work on a limited known set of verbose data, we have to pass a lot of parameters around. This PR experiments with adding a type of DTO called the CoreDataObject which is not a great name, but once I or someone else comes up with a better one it's easy to refactor.
Anyhow, this immutable DTO contains only data known at the earliest point in construction solving the problem of factories needing to depend on data that might not be generated yet which is the reason for having the scoped private data as it is now.
In summary, this PR doesn't change the fundamental design of the page factory data pipeline, it just aims to reduce boilerplate by having a single well defined data object that can be passed around to subfactories more easily.