Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactors #590

Merged
merged 14 commits into from
Oct 26, 2022
Merged

Code refactors #590

merged 14 commits into from
Oct 26, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #590 (695f902) into master (ed0bd8e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 695f902 differs from pull request most recent head 9853607. Consider uploading reports for the commit 9853607 to get more accurate results

@@            Coverage Diff            @@
##             master     #590   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
  Complexity      975      975           
=========================================
  Files           114      114           
  Lines          2411     2411           
=========================================
  Hits           2410     2410           
  Misses            1        1           
Impacted Files Coverage Δ
...s/framework/src/Models/Pages/DocumentationPage.php 100.00% <ø> (ø)
...ckages/framework/src/Models/Pages/MarkdownPost.php 100.00% <ø> (ø)
packages/framework/src/Models/Support/Route.php 100.00% <ø> (ø)
packages/framework/src/Services/RssFeedService.php 100.00% <ø> (ø)
...framework/src/Concerns/JsonSerializesArrayable.php 100.00% <100.00%> (ø)
...ork/src/Foundation/Concerns/ForwardsHyperlinks.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Replace code comment with helper method

Document why the marker is needed

Inline variable

Format code style

Shorten helper method name

Refactor code flow
@caendesilva caendesilva marked this pull request as ready for review October 26, 2022 14:51
@caendesilva caendesilva merged commit 8c99b44 into master Oct 26, 2022
@caendesilva caendesilva deleted the code-refactors branch October 26, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants