Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XML support to File.php #563

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

LunarMarathon
Copy link
Contributor

Solves issue #562

Let me know if any changes needs to be made. I used appilication/xml instead of text/xml as the former was recommended. I could learn something new, thanks for the opportunity!

Copy link
Member

@caendesilva caendesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! You found the right mime-type; application/xml is indeed what I was looking for, and I'm very happy you learned something! Thank you for your contribution and have a happy Hacktoberfest!

@LunarMarathon
Copy link
Contributor Author

Thank you! Wish you the same!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants