Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename build hooks to build tasks #459

Merged
merged 9 commits into from
Sep 1, 2022
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Sep 1, 2022

Refactors the build hook service and renames it to build task service as we are dealing with tasks and not hooks. This makes it more consistent. The hook part is just that the tasks are automatically run in the build process.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #459 (8e697e4) into master (043405e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8e697e4 differs from pull request most recent head 2ec5357. Consider uploading reports for the commit 2ec5357 to get more accurate results

@@            Coverage Diff            @@
##             master     #459   +/-   ##
=========================================
  Coverage     99.60%   99.60%           
  Complexity      923      923           
=========================================
  Files           109      109           
  Lines          2281     2281           
=========================================
  Hits           2272     2272           
  Misses            9        9           
Impacted Files Coverage Δ
...ages/framework/src/Contracts/AbstractBuildTask.php 100.00% <ø> (ø)
...ckages/framework/src/Services/BuildTaskService.php 100.00% <ø> (ø)
...mework/src/Commands/HydeBuildStaticSiteCommand.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review September 1, 2022 08:35
@caendesilva caendesilva changed the title Refactor build task service Rename build hooks to build tasks Sep 1, 2022
@caendesilva caendesilva merged commit 1100a10 into master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants