-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor auxiliary build services and tasks #453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
changed the title
Update build hooks
Refactor auxiliary build services and tasks
Aug 31, 2022
caendesilva
force-pushed
the
update-build-hooks
branch
from
August 31, 2022 17:15
9025c1f
to
fb757cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
============================================
- Coverage 99.95% 99.60% -0.36%
+ Complexity 924 919 -5
============================================
Files 107 109 +2
Lines 2277 2267 -10
============================================
- Hits 2276 2258 -18
- Misses 1 9 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Coverage is in large part failing due to there not being any coverage for the deprecated test, that's fine for this PR as it will be resolved in the upcoming release that removes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update refactors the build services for the generation of sitemaps, RSS feeds, and documentation search index. These are now handled by post-build tasks, and are simplified.
Much of the return information has been removed as well as preflight checks. We may want to add some exceptions in the related services as the following messages (among others) have been removed
site.generate_sitemap
totrue
simplexml
extension installed. Check your PHP installation.I also had to remove the output message tests as they stopped working, but they are present in the terminal when running builds. See 19d3e7d