Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auxiliary build services and tasks #453

Merged
merged 43 commits into from
Aug 31, 2022
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 31, 2022

This update refactors the build services for the generation of sitemaps, RSS feeds, and documentation search index. These are now handled by post-build tasks, and are simplified.

Much of the return information has been removed as well as preflight checks. We may want to add some exceptions in the related services as the following messages (among others) have been removed

  • Cannot generate sitemap.xml, please check your configuration.
  • You don't have a site URL configured. Check config/hyde.php
  • You have disabled sitemap generation in config/hyde.php
  • You can enable sitemap generation by setting site.generate_sitemap to true
  • Cannot generate sitemap.xml, please check your configuration.
  • You don't have the simplexml extension installed. Check your PHP installation.

I also had to remove the output message tests as they stopped working, but they are present in the terminal when running builds. See 19d3e7d

@caendesilva caendesilva changed the title Update build hooks Refactor auxiliary build services and tasks Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #453 (fe20c62) into master (1afa4de) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #453      +/-   ##
============================================
- Coverage     99.95%   99.60%   -0.36%     
+ Complexity      924      919       -5     
============================================
  Files           107      109       +2     
  Lines          2277     2267      -10     
============================================
- Hits           2276     2258      -18     
- Misses            1        9       +8     
Impacted Files Coverage Δ
packages/framework/src/Concerns/ActionCommand.php 0.00% <ø> (-100.00%) ⬇️
...ork/src/Actions/PostBuildTasks/GenerateRssFeed.php 100.00% <100.00%> (ø)
...work/src/Actions/PostBuildTasks/GenerateSearch.php 100.00% <100.00%> (ø)
...ork/src/Actions/PostBuildTasks/GenerateSitemap.php 100.00% <100.00%> (ø)
...framework/src/Commands/HydeBuildRssFeedCommand.php 100.00% <100.00%> (ø)
.../framework/src/Commands/HydeBuildSearchCommand.php 100.00% <100.00%> (ø)
...framework/src/Commands/HydeBuildSitemapCommand.php 100.00% <100.00%> (ø)
...mework/src/Commands/HydeBuildStaticSiteCommand.php 100.00% <100.00%> (ø)
...ages/framework/src/Contracts/AbstractBuildTask.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva
Copy link
Member Author

Coverage is in large part failing due to there not being any coverage for the deprecated test, that's fine for this PR as it will be resolved in the upcoming release that removes it.

@caendesilva caendesilva marked this pull request as ready for review August 31, 2022 17:39
@caendesilva caendesilva merged commit c3dc3d0 into master Aug 31, 2022
@caendesilva caendesilva deleted the update-build-hooks branch August 31, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants