Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle todo comments #446

Merged
merged 7 commits into from
Aug 28, 2022
Merged

Handle todo comments #446

merged 7 commits into from
Aug 28, 2022

Commits on Aug 28, 2022

  1. Remove todo regarding caching 

    I think the RC is fast enough, and caching would introduce a lot of complexity which I believe is unproportionable to the value it gives
    @caendesilva
    caendesilva committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    d1b3c81 View commit details
    Browse the repository at this point in the history

  2. Remove todos, if it ain't broke, don't fix it

    @caendesilva
    caendesilva committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    c7c6d06 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into handle-todos

    @caendesilva
    caendesilva committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    585d606 View commit details
    Browse the repository at this point in the history

  4. Link to GitHub issue

    @caendesilva
    caendesilva committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    1bb8b7c View commit details
    Browse the repository at this point in the history

  5. Create GitHub issue

    @caendesilva
    caendesilva committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    cefd1ec View commit details
    Browse the repository at this point in the history

  6. Merge test into FilesystemTest

    @caendesilva
    caendesilva committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    4f842a6 View commit details
    Browse the repository at this point in the history

  7. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    d4cbe63 View commit details
    Browse the repository at this point in the history