Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality improvements #413

Merged
merged 15 commits into from
Aug 11, 2022
Merged

Code quality improvements #413

merged 15 commits into from
Aug 11, 2022

Conversation

caendesilva
Copy link
Member

Fixes some more issues discovered by Scrutinizer

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #413 (49e886d) into master (866ede9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #413   +/-   ##
=========================================
  Coverage     99.81%   99.82%           
+ Complexity      900      899    -1     
=========================================
  Files           100      100           
  Lines          2222     2223    +1     
=========================================
+ Hits           2218     2219    +1     
  Misses            4        4           
Impacted Files Coverage Δ
...ackages/framework/src/Models/Metadata/Metadata.php 100.00% <100.00%> (ø)
packages/framework/src/Services/RssFeedService.php 100.00% <100.00%> (ø)
packages/framework/src/Services/SitemapService.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review August 11, 2022 21:13
@caendesilva caendesilva merged commit 81caef1 into master Aug 11, 2022
@caendesilva caendesilva deleted the code-quality branch August 11, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants