Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle complex parsing logic in new parser action #325

Merged
merged 24 commits into from
Aug 3, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Aug 3, 2022

Moves more of the complex parsing logic like dynamic titles and sidebar categories to the new parser action.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #325 (41ff3ef) into master (6a0eb4d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #325      +/-   ##
============================================
- Coverage     99.85%   99.85%   -0.01%     
+ Complexity      831      825       -6     
============================================
  Files            96       94       -2     
  Lines          2049     2039      -10     
============================================
- Hits           2046     2036      -10     
  Misses            3        3              
Impacted Files Coverage Δ
...s/framework/src/Models/Pages/DocumentationPage.php 100.00% <ø> (ø)
.../Actions/GeneratesDocumentationSearchIndexFile.php 100.00% <100.00%> (ø)
...ackages/framework/src/Actions/SourceFileParser.php 100.00% <100.00%> (ø)
...s/framework/src/Contracts/AbstractMarkdownPage.php 100.00% <100.00%> (ø)
packages/framework/src/Services/RssFeedService.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Improve file parsing Handle complex parsing logic in new parser action Aug 3, 2022
@caendesilva caendesilva marked this pull request as ready for review August 3, 2022 18:24
@caendesilva caendesilva merged commit c7f34a0 into master Aug 3, 2022
@caendesilva caendesilva deleted the improve-file-parsing branch August 3, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants