Remove DocumentationPage localPath property

RELEASE_NOTES.md

@@ -13,13 +13,13 @@ This serves two purposes:
 - for new features.
 
 ### Changed
-- for changes in existing functionality.
+- internal: The DocumentationPage slug now behaves like other pages, and the basename is produced at runtime, see below
 
 ### Deprecated
 - for soon-to-be removed features.
 
 ### Removed
-- for now removed features.
+- Removed `$localPath` property from DocumentationPage class, see above
 
 ### Fixed
 - for any bug fixes.

packages/framework/src/Actions/SourceFileParser.php

@@ -100,7 +100,6 @@ protected function parseDocumentationPage(): DocumentationPage
             title: FindsTitleForDocument::get($this->slug, $matter, $body),
             slug: basename($this->slug),
             category: $this->getDocumentationPageCategory($matter),
-            localPath: $this->slug
         );
     }
 

packages/framework/src/Models/Pages/DocumentationPage.php

@@ -20,23 +20,16 @@ class DocumentationPage extends AbstractMarkdownPage
      */
     public ?string $category;
 
-    /**
-     * The path to the page relative to the configured `_docs` directory.
-     * Generally only needed if the page is in a subdirectory.
-     */
-    public ?string $localPath;
-
-    public function __construct(array $matter = [], string $body = '', string $title = '', string $slug = '', ?string $category = null, ?string $localPath = null)
+    public function __construct(array $matter = [], string $body = '', string $title = '', string $slug = '', ?string $category = null)
     {
         parent::__construct($matter, $body, $title, $slug);
         $this->category = $category;
-        $this->localPath = $localPath;
     }
 
     /** @inheritDoc */
-    public function getSourcePath(): string
+    public function getCurrentPagePath(): string
     {
-        return is_null($this->localPath) ? parent::getSourcePath() : static::qualifyBasename($this->localPath);
+        return trim(static::getOutputDirectory().'/'.basename($this->slug), '/');
     }
 
     /** @internal */

packages/framework/tests/Unit/DocumentationPageTest.php

@@ -122,4 +122,10 @@ public function test_has_table_of_contents()
         Config::set('docs.table_of_contents.enabled', false);
         $this->assertFalse(DocumentationPage::hasTableOfContents());
     }
+
+    public function test_compiled_pages_originating_in_subdirectories_get_output_to_root_docs_path()
+    {
+        $page = (new DocumentationPage([], '', '', 'foo/bar'));
+        $this->assertEquals('docs/bar.html', $page->getOutputPath());
+    }
 }