Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated LegacyPageRouter from HydeRC #314

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,20 @@

### About

Keep an Unreleased section at the top to track upcoming changes.

This serves two purposes:

1. People can see what changes they might expect in upcoming releases
2. At release time, you can move the Unreleased section changes into a new release version section.
This update removes the deprecated LegacyPageRouter class from the Hyde Realtime Compiler (HydeRC). Along with this release, the HydeRC is now on version 2.5, and requires Hyde version 0.48.0-beta or higher.

### Added
- for new features.

### Changed
- for changes in existing functionality.
- hyde/realtime-compiler no longer supports Framework versions older than v0.48.0-beta.
- hyde/hyde now requires HydeRC version 2.5 or higher.

### Deprecated
- for soon-to-be removed features.

### Removed
- for now removed features.
- Remove the deprecated LegacyPageRouter class from the HydeRC.

### Fixed
- for any bug fixes.
Expand Down
2 changes: 1 addition & 1 deletion packages/hyde/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"laravel-zero/framework": "^9.1"
},
"require-dev": {
"hyde/realtime-compiler": "^2.4"
"hyde/realtime-compiler": "^2.5"
},
"autoload": {
"psr-4": {
Expand Down
2 changes: 1 addition & 1 deletion packages/realtime-compiler/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
"hyde/framework": "dev-master"
},
"suggest": {
"hyde/framework": ">=v0.42.0-beta"
"hyde/framework": ">=v0.48.0-beta"
}
}
110 changes: 0 additions & 110 deletions packages/realtime-compiler/src/Routing/LegacyPageRouter.php

This file was deleted.

5 changes: 0 additions & 5 deletions packages/realtime-compiler/src/Routing/Router.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ public function handle(): Response
}
}

// Temporary backwards compatibility for versions less than Hyde/Framework v0.48.0-beta
if (! class_exists('\Hyde\Framework\Services\RoutingService')) {
return LegacyPageRouter::handle($this->request);
}

return PageRouter::handle($this->request);
}

Expand Down