Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use features class in more places #312

Merged
merged 30 commits into from
Aug 1, 2022
Merged

Refactor to use features class in more places #312

merged 30 commits into from
Aug 1, 2022

Commits on Jul 31, 2022

  1. Remove redundant arguments

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    013e7e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-code-issues

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    95384bf View commit details
    Browse the repository at this point in the history

  3. Reformat code comments

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    9c13507 View commit details
    Browse the repository at this point in the history

  4. Link to the test

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    1027606 View commit details
    Browse the repository at this point in the history

  5. Add Features::sitemap() helper

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    486d0cd View commit details
    Browse the repository at this point in the history

  6. Add custom failure messages to dynamic matrix assertions

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    ffcf984 View commit details
    Browse the repository at this point in the history

  7. Replace Replaced SitemapService::canGenerateSitemap with Features::si… 

    …temap
    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    c71f299 View commit details
    Browse the repository at this point in the history

  8. Inline simple conditional method

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    7c91a92 View commit details
    Browse the repository at this point in the history

  9. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    2947a39 View commit details
    Browse the repository at this point in the history

  10. Remove unused import

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    edaf49c View commit details
    Browse the repository at this point in the history

  11. Remove checks that only adds RSS feed link on home and post pages 

    I actually don't really see a reason for this. Maybe you wouldn't want it on a documentation site, but I don't think that complexity is warranted now, and it's not within the 80% use case.
    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    a93e300 View commit details
    Browse the repository at this point in the history

  12. Inline simple conditional method

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    5a94826 View commit details
    Browse the repository at this point in the history

  13. Move RssFeedService::canGenerateFeed to Features::canGenerateFeed(

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    3618422 View commit details
    Browse the repository at this point in the history

  14. Rename Features::canGenerateFeed to Features::rss

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    c7aac47 View commit details
    Browse the repository at this point in the history

  15. Update RELEASE_NOTES.md

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    ad0f17e View commit details
    Browse the repository at this point in the history

  16. Merge branch 'update-features-class' of github.com:hydephp/develop in… 

    …to update-features-class
    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    62c661b View commit details
    Browse the repository at this point in the history

  17. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    ba9543a View commit details
    Browse the repository at this point in the history

  18. Change type to static

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    0b6259b View commit details
    Browse the repository at this point in the history

  19. Add method annotations

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    c210465 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'update-features-class' of github.com:hydephp/develop in… 

    …to update-features-class
    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    2cb4617 View commit details
    Browse the repository at this point in the history

  21. Assert contains instead of equals 

    This was added I think to show that no extra tags were added, but that violates the principle of only testing one thing, it's better to add a specific test for that
    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    8f9ad9b View commit details
    Browse the repository at this point in the history

  22. Add method unit smoke test

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    40ba41e View commit details
    Browse the repository at this point in the history

  23. Replace mock with actual instance

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    ef0fd91 View commit details
    Browse the repository at this point in the history

  24. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    879d424 View commit details
    Browse the repository at this point in the history

  25. RSS feed is now always present on all pages

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    769b628 View commit details
    Browse the repository at this point in the history

  26. Update RELEASE_NOTES.md

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    03f524f View commit details
    Browse the repository at this point in the history

  27. Remove outdated coverage annotation

    @caendesilva
    caendesilva committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    4758d14 View commit details
    Browse the repository at this point in the history

  28. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    44f9c0a View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Deprecate trait HasMarkdownFeatures

    @caendesilva
    caendesilva committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    a6f5545 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'update-features-class' of github.com:hydephp/develop in… 

    …to update-features-class
    @caendesilva
    caendesilva committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    76cb1d7 View commit details
    Browse the repository at this point in the history