Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sidebar views #287

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Rename sidebar views #287

merged 4 commits into from
Jul 29, 2022

Conversation

caendesilva
Copy link
Member

Some of these component names were really long, and overly specific. We don't need to point out that the sidebar component is a "sidebar navigation menu" -- it's not like we have other types of sidebars.

@caendesilva
Copy link
Member Author

I do think I want to refactor the entire docs layout to be more component based, but that's for another release.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #287 (8775e6a) into master (f3d35ea) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master      #287   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       801       801           
===========================================
  Files             97        97           
  Lines           2006      2006           
===========================================
  Hits            2006      2006           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d35ea...8775e6a. Read the comment docs.

@caendesilva caendesilva marked this pull request as ready for review July 29, 2022 16:18
@caendesilva caendesilva merged commit 940f24d into master Jul 29, 2022
@caendesilva caendesilva deleted the rename-sidebar-views branch July 29, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant