Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Test code refactors and cleanup #1960

Merged
merged 73 commits into from
Sep 10, 2024
Merged

Internal: Test code refactors and cleanup #1960

merged 73 commits into from
Sep 10, 2024

Commits on Sep 8, 2024

  1. Remove unnecessary setup logic

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    542f05c View commit details
    Browse the repository at this point in the history

  2. Inline simplified testing helper method alias

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e17c37f View commit details
    Browse the repository at this point in the history

  3. Normalize static method access

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    059ddaf View commit details
    Browse the repository at this point in the history

  4. Use a better test method name

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    330f089 View commit details
    Browse the repository at this point in the history

  5. Add linting rule against using useless parent calls in unit tests

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    40e3dfe View commit details
    Browse the repository at this point in the history

  6. Remove useless parent calls in unit tests

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    2095b8c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into test-cleanup

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    c03766f View commit details
    Browse the repository at this point in the history

  8. Refactor unit test to mock the filesystem

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    c6787fa View commit details
    Browse the repository at this point in the history

  9. Extract helper method to mock the filesystem

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    0a40852 View commit details
    Browse the repository at this point in the history

  10. Return the mocked filesystem

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    b5dd609 View commit details
    Browse the repository at this point in the history

  11. Refactor to use a tap call

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    abfe1bf View commit details
    Browse the repository at this point in the history

  12. Use a traditional closure

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1da6f5c View commit details
    Browse the repository at this point in the history

  13. Refactor to use a tap call

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    5fb412e View commit details
    Browse the repository at this point in the history

  14. Refactor to use a tap call

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    4f1a518 View commit details
    Browse the repository at this point in the history

  15. Extract helper to verify mockery expectations

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    adc511c View commit details
    Browse the repository at this point in the history

  16. Extract common code for filesystem mocking

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    cedab99 View commit details
    Browse the repository at this point in the history

  17. Refactor unit test to use unit test case

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d0834e5 View commit details
    Browse the repository at this point in the history

  18. Update parser to use mockable filesystem facade

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    aae35d8 View commit details
    Browse the repository at this point in the history

  19. Make parameter optional

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    85810be View commit details
    Browse the repository at this point in the history

  20. Annotate the return type combination

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    f29d54f View commit details
    Browse the repository at this point in the history

  21. Compress comment

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    467ac9f View commit details
    Browse the repository at this point in the history

  22. Add parameter to control partial mock

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    fbc608e View commit details
    Browse the repository at this point in the history

  23. Revert "Add parameter to control partial mock" 

    This reverts commit fbc608e.
    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    9c950ae View commit details
    Browse the repository at this point in the history

  24. Add method without partial mock

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    26bfbe1 View commit details
    Browse the repository at this point in the history

  25. Forward methods using argument list function to make mocking easier 

    And way less confusing...
    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    18a2652 View commit details
    Browse the repository at this point in the history

  26. Extract unit test and refactor it to be ten times faster 

    Now runs in 0.065s instead of 0.70s
    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    00b5148 View commit details
    Browse the repository at this point in the history

  27. Refactor unit test to mock the filesystem

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6b3bff3 View commit details
    Browse the repository at this point in the history

  28. Extract helper for mocking the filesystem calls

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    07057c4 View commit details
    Browse the repository at this point in the history

  29. Inline local variables

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6da08c1 View commit details
    Browse the repository at this point in the history

  30. Set expectations to once

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    c3dddb2 View commit details
    Browse the repository at this point in the history

  31. Verify mockery expectations at teardown

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    495e0af View commit details
    Browse the repository at this point in the history

  32. Remove method no longer called by fixed mocks

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    91f034f View commit details
    Browse the repository at this point in the history

  33. Generate test for HtmlPage class

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    7bc8e81 View commit details
    Browse the repository at this point in the history

  34. Revert "Generate test for HtmlPage class" 

    This reverts commit 7bc8e81.
    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ab6e886 View commit details
    Browse the repository at this point in the history

  35. Allow dynamic properties in test

    @caendesilva
    caendesilva committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    75ad4a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Refactor to use the new filesystem mocking helper

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    17e3941 View commit details
    Browse the repository at this point in the history

  2. Convert closures to arrow functions

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    eca861c View commit details
    Browse the repository at this point in the history

  3. Normalize closure syntax

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c5594a9 View commit details
    Browse the repository at this point in the history

  4. Extract helper method to set up the mocks

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6f21293 View commit details
    Browse the repository at this point in the history

  5. Extract helper method create mocks

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e423d8a View commit details
    Browse the repository at this point in the history

  6. Add newline to code

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    452811a View commit details
    Browse the repository at this point in the history

  7. Refactor unit test to extend unit test case 

    Runs in 60ms instead of 285ms
    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    28f938d View commit details
    Browse the repository at this point in the history

  8. Update class to use mockable filesystem helper

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    cd883e8 View commit details
    Browse the repository at this point in the history

  9. Refactor test to mock the filesystem

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    06a2bd8 View commit details
    Browse the repository at this point in the history

  10. Extract fluent expectation helpers

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1a93e73 View commit details
    Browse the repository at this point in the history

  11. Verify mockery expectations at tear down

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c03b9eb View commit details
    Browse the repository at this point in the history

  12. Merge unit test into feature test

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    36e2413 View commit details
    Browse the repository at this point in the history

  13. Move test to more suitable test class

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3d79c44 View commit details
    Browse the repository at this point in the history

  14. Merge unit test into service feature test

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    456b087 View commit details
    Browse the repository at this point in the history

  15. Update unit test to use the unit test case

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8789fa3 View commit details
    Browse the repository at this point in the history

  16. Add a weak warning when unit tests don't use the unit test case

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    09dd00d View commit details
    Browse the repository at this point in the history

  17. Add HydeStan helper to create a todo list

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ad55e0c View commit details
    Browse the repository at this point in the history

  18. Refactor test to unit test 

    Saves about 100ms (down from 300ms)
    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e2b90b5 View commit details
    Browse the repository at this point in the history

  19. Refactor unit test to use the unit test case

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    40bf24d View commit details
    Browse the repository at this point in the history

  20. Remove redundant arguments

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6aa8237 View commit details
    Browse the repository at this point in the history

  21. Remove useless assertion

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a64453c View commit details
    Browse the repository at this point in the history

  22. Add additional tests

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9165a16 View commit details
    Browse the repository at this point in the history

  23. Refactor unit test to use the unit test case

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e1123dd View commit details
    Browse the repository at this point in the history

  24. Update testing helper to redirect to main helper

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    62b756a View commit details
    Browse the repository at this point in the history

  25. Update testing helper to work on unit tests

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4a8a554 View commit details
    Browse the repository at this point in the history

  26. Refactor unit test to use unit test case 

    Now runs in 30ms instead of almost 500ms...
    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    59a999a View commit details
    Browse the repository at this point in the history

  27. Refactor to use the unit test case

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ead940e View commit details
    Browse the repository at this point in the history

  28. Slim down formatting

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f40c204 View commit details
    Browse the repository at this point in the history

  29. Refactor to use the unit test case

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1da2b96 View commit details
    Browse the repository at this point in the history

  30. Unit view tests are allowed to extend TestCase

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    11a1e9b View commit details
    Browse the repository at this point in the history

  31. Mark analysed expressions

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    57c3993 View commit details
    Browse the repository at this point in the history

  32. Move test to the proper namespace

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e9e650d View commit details
    Browse the repository at this point in the history

  33. Forget any mock instances

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d1415d0 View commit details
    Browse the repository at this point in the history

  34. Use the unit test case

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    22dcace View commit details
    Browse the repository at this point in the history

  35. Add section completion output

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    416671e View commit details
    Browse the repository at this point in the history

  36. Normalize view unit test name

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b3f839f View commit details
    Browse the repository at this point in the history

  37. Refactor to unit test and use filesystem mocks

    @caendesilva
    caendesilva committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    13444a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Refactor test to be proper unit test with filesystem mocks

    @caendesilva
    caendesilva committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    66f6a21 View commit details
    Browse the repository at this point in the history