[2.x] Add booting and booted callbacks to the HydeExtension feature #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much more elegant idea by Claude, compared to what I was thinking (looping extensions before/after boot)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1847 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1855 1857 +2
===========================================
Files 190 190
Lines 4909 4914 +5
===========================================
+ Hits 4909 4914 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR enhances the Extensions API by adding support for
bootingandbootedcallbacks directly in theHydeExtensionclass. This allows extension developers to hook into the Hyde kernel's boot process more easily and perform setup or cleanup tasks.Changes
booting()andbooted()methods toHydeExtensionclassManagesExtensionstrait to register these callbacksBootsHydeKerneltrait to call the new callbacksUpgrade Notes
This change is backwards-compatible and requires no changes for existing extensions. However, developers can now take advantage of these new methods to perform actions during the kernel boot process.